Skip to content

fix: Add wait for cache sync for customresourcediscovery tests #132517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix: Add wait for cache sync for customresourcediscovery tests #132517

merged 1 commit into from
Jun 25, 2025
+2 −0

Conversation

michaelasp
Copy link
Contributor

@michaelasp michaelasp commented Jun 24, 2025 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Fix flake where we don't sync informer cache before starting tests

Which issue(s) this PR is related to:

Fixes #132418

Special notes for your reviewer:

Similar issue to #120109

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @michaelasp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2025
@michaelasp
Copy link
Contributor Author

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt June 24, 2025 22:22
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from roycaihw and sttts June 24, 2025 22:22
@michaelasp
Copy link
Contributor Author 

maspinwall@maspinwall:~/oss/kubernetes$ stress ./apiserver.test -test.run TestResourceManagerAddedCRD
5s: 2229 runs so far, 0 failures, 128 active
10s: 4605 runs so far, 0 failures, 128 active
15s: 6978 runs so far, 0 failures, 128 active
20s: 9353 runs so far, 0 failures, 128 active
25s: 11752 runs so far, 0 failures, 128 active
30s: 14193 runs so far, 0 failures, 128 active
35s: 16612 runs so far, 0 failures, 128 active
40s: 19012 runs so far, 0 failures, 128 active
45s: 21452 runs so far, 0 failures, 128 active
50s: 23885 runs so far, 0 failures, 128 active
55s: 26275 runs so far, 0 failures, 128 active
1m0s: 28732 runs so far, 0 failures, 128 active
1m5s: 31163 runs so far, 0 failures, 128 active
1m10s: 33565 runs so far, 0 failures, 128 active
1m15s: 36008 runs so far, 0 failures, 128 active
1m20s: 38439 runs so far, 0 failures, 128 active
1m25s: 40848 runs so far, 0 failures, 128 active
1m30s: 43248 runs so far, 0 failures, 128 active

Previously was getting ~1% flake rate

@michaelasp
Copy link
Contributor Author

/cc @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea June 24, 2025 22:28
@liggitt
Copy link
Member

liggitt commented Jun 25, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2025
@liggitt
Copy link
Member

liggitt commented Jun 25, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d3ae8abd62a40ae55dc5a5438b20d70c8691ed4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, michaelasp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7f4996b into kubernetes:master Jun 25, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@roycaihw roycaihw Awaiting requested review from roycaihw

@sttts sttts Awaiting requested review from sttts

@aojea aojea Awaiting requested review from aojea

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

[Flaking Test] UT k8s.io/apiextensions-apiserver/pkg: apiserver
3 participants
@michaelasp @k8s-ci-robot @liggitt