-
Notifications
You must be signed in to change notification settings - Fork 40.9k
fix: Add wait for cache sync for customresourcediscovery tests #132517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @michaelasp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @liggitt |
maspinwall@maspinwall:~/oss/kubernetes$ stress ./apiserver.test -test.run TestResourceManagerAddedCRD
5s: 2229 runs so far, 0 failures, 128 active
10s: 4605 runs so far, 0 failures, 128 active
15s: 6978 runs so far, 0 failures, 128 active
20s: 9353 runs so far, 0 failures, 128 active
25s: 11752 runs so far, 0 failures, 128 active
30s: 14193 runs so far, 0 failures, 128 active
35s: 16612 runs so far, 0 failures, 128 active
40s: 19012 runs so far, 0 failures, 128 active
45s: 21452 runs so far, 0 failures, 128 active
50s: 23885 runs so far, 0 failures, 128 active
55s: 26275 runs so far, 0 failures, 128 active
1m0s: 28732 runs so far, 0 failures, 128 active
1m5s: 31163 runs so far, 0 failures, 128 active
1m10s: 33565 runs so far, 0 failures, 128 active
1m15s: 36008 runs so far, 0 failures, 128 active
1m20s: 38439 runs so far, 0 failures, 128 active
1m25s: 40848 runs so far, 0 failures, 128 active
1m30s: 43248 runs so far, 0 failures, 128 active Previously was getting ~1% flake rate |
/cc @aojea |
/ok-to-test |
/lgtm |
LGTM label has been added. Git tree hash: 6d3ae8abd62a40ae55dc5a5438b20d70c8691ed4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, michaelasp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Fix flake where we don't sync informer cache before starting tests
Which issue(s) this PR is related to:
Fixes #132418
Special notes for your reviewer:
Similar issue to #120109
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: