Skip to content

emeritus spiffxp and backfill OWNERS #132220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

emeritus spiffxp and backfill OWNERS #132220

merged 4 commits into from
Jun 26, 2025

Conversation

BenTheElder
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes a long inactive approver, backfills some current reviewers/approvers in place.

I'm signing up for some reviews, and for the sig-testing specific alias I'm adding the other current testing TLs.

Which issue(s) this PR is related to:

Special notes for your reviewer:

I put more details in the commit messages, but in particular:

I have been active in Kubernetes testing and conformance related discussions and PRs for 8+ years now and I am a SIG Testing TL. I'd lke to help review these additional directories.

I already approve the test/, including nearly all of the e2e tests and images, and the conformance image in particular for many years now.

... I'm hoping folks are familiar with my participation by now 🙃

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @dims
/assign @dims
/sig testing architecture

@BenTheElder
emeritus spiffxp
ad68a4b 
spiffxp moved on from the project years ago, he is still missed
@BenTheElder
backfill some sig-testing-reviewers (tech leads aojea and pohly)
1dd0557
@BenTheElder
add bentheelder to conformance related test *reviewers*
00a6d2c 
To backfill from removing spiffxp. I have been active in Kubernetes testing and conformance related discussions and PRs for 8+ years now and I am a SIG Testing TL. I'd lke to help review these additional directories.

I already approve the test/, including nearly all of the e2e tests and images, and the conformance image in particular for many years now.
@BenTheElder
add bentheelder to cmd/preferredimports *reviewers*
2810f6e 
I'm not sure the one remaining reviewer is active, I am active in code organization and build + test tooling for many years now.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dims June 11, 2025 03:13
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 11, 2025
@aojea
Copy link
Member

aojea commented Jun 12, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed1830e82f26de384f7212a4b24b351eab1e3797

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jun 12, 2025
Open
@cici37
Copy link
Contributor

cici37 commented Jun 12, 2025

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 12, 2025
@dims
Copy link
Member

dims commented Jun 26, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit b3e438a into kubernetes:master Jun 26, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 26, 2025
@BenTheElder BenTheElder deleted the a-little-owners-cleanup branch June 26, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@BenTheElder @k8s-ci-robot @aojea @cici37 @dims