Skip to content

Promote RelaxedEnvironmentVariableValidation test to Conformance #132219 #132264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Promote RelaxedEnvironmentVariableValidation test to Conformance #132219 #132264

wants to merge 1 commit into from

Conversation

HirazawaUi
Copy link
Contributor

@HirazawaUi HirazawaUi commented Jun 12, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

The RelaxedEnvironmentVariableValidation feature gate has now reached GA stage. We are promoting its related tests to the Conformance test, This is follow up to #132054 .

Which issue(s) this PR is related to:

Special notes for your reviewer:

Tests are reliably green here:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4369-allow-special-characters-environment-variable

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 12, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dims June 12, 2025 13:51
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 12, 2025
@HirazawaUi
Copy link
Contributor Author

/cc @SergeyKanzhelev

SergeyKanzhelev
SergeyKanzhelev approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59506dee10cf8ef814f2b5d57c26bcccca954d61

@SergeyKanzhelev
Copy link
Member

/assign @dims

Robot's suggestion is not great because of #132220

@dims
Copy link
Member

dims commented Jun 12, 2025

@HirazawaUi @SergeyKanzhelev

Please remind me when you hit the 2 week mark https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md?plain=1#L54-L55

as it looks like the updated tests just landed 2 days ago - #132054

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2025
@SergeyKanzhelev
Copy link
Member

@HirazawaUi @SergeyKanzhelev

Please remind me when you hit the 2 week mark https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md?plain=1#L54-L55

as it looks like the updated tests just landed 2 days ago - #132054

/hold

My reasoning was that the same test with the other set of characters was running green for a while and this is only the characters set expansion. But yes, we can wait for a couple of weeks, no harm in being on a safer side

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jun 13, 2025
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Waiting on Author in SIG Node: code and documentation PRs Jun 13, 2025
@HirazawaUi
Copy link
Contributor Author

Please remind me when you hit the 2 week mark

It has been two weeks and the tests have been consistently green. Could we lift the hold now?

BenTheElder
BenTheElder reviewed Jun 25, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SergeyKanzhelev
Copy link
Member

/unhold
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HirazawaUi, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please ask for approval from dims. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@dims dims Awaiting requested review from dims

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@dims dims

@BenTheElder BenTheElder

@SergeyKanzhelev SergeyKanzhelev

Labels
area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Archive-it
SIG Node: code and documentation PRs
Status: Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HirazawaUi @k8s-ci-robot @SergeyKanzhelev @dims @BenTheElder