Skip to content

DRA E2E: run some tests without feature label #131956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

DRA E2E: run some tests without feature label #131956

merged 1 commit into from
Jul 1, 2025
+529 −437

Conversation

pohly
Copy link
Contributor

@pohly pohly commented May 25, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Tests which only exercise the control plane don't need DRA drivers on the nodes and thus can run in any cluster where the API and feature gate is enabled. Eventually they can become conformance tests.

Which issue(s) this PR fixes (or partially fixes):

#114183

Special notes for your reviewer:

The actual test cases follow the same pattern and in some cases are run twice, once for "control plane" testing and once for "kubelet" testing. The difference is that in "control plane" mode, the driver's don't get deployed and pods are only expected to get scheduled instead of starting to run.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 25, 2025
@pohly pohly marked this pull request as draft May 25, 2025 18:03
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and klueska May 25, 2025 18:03
@pohly
Copy link
Contributor Author

pohly commented May 25, 2025

/test pull-kubernetes-e2e-kind-dra
/test pull-kubernetes-e2e-kind-beta-features

@pohly pohly mentioned this pull request May 25, 2025
Closed
@pohly
Copy link
Contributor Author

pohly commented May 25, 2025

/test pull-kubernetes-kind-dra
/test pull-kubernetes-kind-dra-all

@pohly pohly mentioned this pull request May 25, 2025
Closed
@pohly
Copy link
Contributor Author

pohly commented May 25, 2025

The "control plane" tests currently fail to tear down pods because of #131957.

@pohly pohly force-pushed the dra-e2e-conformance branch from 7f49575 to df51936 Compare May 25, 2025 18:38
@pohly
Copy link
Contributor Author

pohly commented May 25, 2025

/test pull-kubernetes-kind-dra
/test pull-kubernetes-kind-dra-all
/test pull-kubernetes-e2e-kind-beta-features

@pohly pohly force-pushed the dra-e2e-conformance branch from df51936 to df8500f Compare May 25, 2025 18:59
@pohly
Copy link
Contributor Author

pohly commented May 25, 2025

/test pull-kubernetes-kind-dra
/test pull-kubernetes-kind-dra-all
/test pull-kubernetes-e2e-kind-beta-features

@k8s-ci-robot k8s-ci-robot removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@pohly
Copy link
Contributor Author

pohly commented Jun 26, 2025

/test pull-kubernetes-kind-dra
/test pull-kubernetes-kind-dra-all
/test pull-kubernetes-e2e-kind-beta-features

pohly added a commit to pohly/kubernetes that referenced this pull request Jun 26, 2025
@pohly
merge kubernetes#131956 dra-e2e-conformance
9c31194
@pohly pohly force-pushed the dra-e2e-conformance branch from c3079cf to d6539ff Compare June 27, 2025 07:12
@pohly
Copy link
Contributor Author

pohly commented Jun 27, 2025

/test pull-kubernetes-kind-dra
/test pull-kubernetes-kind-dra-all
/test pull-kubernetes-e2e-kind-beta-features

pohly added a commit to pohly/kubernetes that referenced this pull request Jun 27, 2025
@pohly
merge kubernetes#131956 dra-e2e-conformance
a59b1a3
@pohly pohly marked this pull request as ready for review June 27, 2025 08:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2025
@pohly
Copy link
Contributor Author

pohly commented Jun 27, 2025

@harche: this is ready for review and merging.

pull-kubernetes-e2e-kind-beta-features includes the tests that can run without kubelet (search for [DRA], which finds 19 tests).

@pohly pohly force-pushed the dra-e2e-conformance branch 2 times, most recently from e0552fd to 66a1afb Compare June 27, 2025 16:58
@pohly
DRA E2E: run some tests without feature label
00dd610 
Tests which only exercise the control plane don't need DRA drivers on the nodes
and thus can run in any cluster where the API and feature gate is
enabled. Eventually they can become conformance tests.

The actual test cases follow the same pattern and in some cases are run twice,
once for "control plane" testing and once for "kubelet" testing. The difference
is that in "control plane" mode, the driver's don't get deployed and pods are
only expected to get scheduled instead of starting to run.
@pohly pohly force-pushed the dra-e2e-conformance branch from 66a1afb to 00dd610 Compare June 27, 2025 19:15
@pohly
Copy link
Contributor Author

pohly commented Jun 28, 2025

/assign @bart0sh

@bart0sh
Copy link
Contributor

bart0sh commented Jul 1, 2025

@harche

/assign

@pohly feel free to ping for the review once it is ready.

Looks good to me from the brief look. @harche PTAL.

harche
harche reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@harche harche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cfc2694943e99bf23459bb6f9b81eeb2fe25763

@bart0sh
Copy link
Contributor

bart0sh commented Jul 1, 2025

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2ed7247 into kubernetes:master Jul 1, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 1, 2025
@github-project-automation github-project-automation bot moved this from PRs Waiting on Author to Done in SIG Node CI/Test Board Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harche harche harche left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@klueska klueska Awaiting requested review from klueska

Assignees

@harche harche

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: 🏗 In progress
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
6 participants
@pohly @haircommander @harche @k8s-ci-robot @bart0sh @k8s-triage-robot