-
Notifications
You must be signed in to change notification settings - Fork 40.9k
DRA E2E: run some tests without feature label #131956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/test pull-kubernetes-e2e-kind-dra |
/test pull-kubernetes-kind-dra |
The "control plane" tests currently fail to tear down pods because of #131957. |
7f49575
to
df51936
Compare
/test pull-kubernetes-kind-dra |
df51936
to
df8500f
Compare
/test pull-kubernetes-kind-dra |
1e87a7f
to
c3079cf
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-kind-dra |
c3079cf
to
d6539ff
Compare
/test pull-kubernetes-kind-dra |
@harche: this is ready for review and merging. pull-kubernetes-e2e-kind-beta-features includes the tests that can run without kubelet (search for |
e0552fd
to
66a1afb
Compare
Tests which only exercise the control plane don't need DRA drivers on the nodes and thus can run in any cluster where the API and feature gate is enabled. Eventually they can become conformance tests. The actual test cases follow the same pattern and in some cases are run twice, once for "control plane" testing and once for "kubelet" testing. The difference is that in "control plane" mode, the driver's don't get deployed and pods are only expected to get scheduled instead of starting to run.
66a1afb
to
00dd610
Compare
/assign @bart0sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 3cfc2694943e99bf23459bb6f9b81eeb2fe25763
|
/retest |
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Tests which only exercise the control plane don't need DRA drivers on the nodes and thus can run in any cluster where the API and feature gate is enabled. Eventually they can become conformance tests.
Which issue(s) this PR fixes (or partially fixes):
#114183
Special notes for your reviewer:
The actual test cases follow the same pattern and in some cases are run twice, once for "control plane" testing and once for "kubelet" testing. The difference is that in "control plane" mode, the driver's don't get deployed and pods are only expected to get scheduled instead of starting to run.
Does this PR introduce a user-facing change?