Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes #124140

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes #124140

merged 1 commit into from
Apr 5, 2024

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Apr 1, 2024 •
edited

Cherry pick of #124048 on release-1.29.

#124048: Use the right feature gate when updating uncertain volumes

For details on the cherry pick process, see the cherry pick requests page.

Fix pod restart after node reboot when NewVolumeManagerReconstruction feature gate is enabled and SELinuxMountReadWriteOncePod disabled

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 1, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Apr 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 1, 2024
@bertinatto bertinatto mentioned this pull request Apr 1, 2024
Merged
@carlory
Copy link
Member

carlory commented Apr 2, 2024

/test pull-kubernetes-integration

@carlory
Copy link
Member

carlory commented Apr 2, 2024

/lgtm
/triage accepted
/kind bug
/assign @jsafrane

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. labels Apr 2, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a367d05fc89e31ffc456e807bf847b10f3937f08

@carlory
Copy link
Member

carlory commented Apr 2, 2024

/test pull-kubernetes-integration

@jsafrane
Copy link
Member

jsafrane commented Apr 3, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 3, 2024
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Apr 3, 2024
@bart0sh bart0sh moved this from Needs Approver to Done in SIG Node PR Triage Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c1d78b into kubernetes:release-1.29 Apr 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

Assignees

@jsafrane jsafrane

@carlory carlory

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
[sig-release] Bug Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bertinatto @carlory @k8s-ci-robot @jsafrane @saschagrunert