Automated cherry pick of #123532: Prevent watch cache starvation, by moving its watch to #123694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd add a SeparateCacheWatchRPC feature flag to disable this behavior
MadhavJivrajani
approved these changes
Mar 5, 2024
|
/lgtm @kubernetes/release-managers - for cherrypick approval |
|
LGTM label has been added. Git tree hash: 9580e1c363fd1fb0934b5c39629de263768ac1e3
|
|
cc: 1.28 release branch manager @ameukam |
|
/assign @ameukam |
Comment on lines
+169
to
+175
| // owner: @serathius | ||
| // beta: v1.30 | ||
| // | ||
| // Allow watch cache to create a watch on a dedicated RPC. | ||
| // This prevents watch cache from being starved by other watches. | ||
| SeparateCacheWatchRPC featuregate.Feature = "SeparateCacheWatchRPC" | ||
|
|
There was a problem hiding this comment.
Having a hard time to understand that this isn't a feature backport.
What are your thoughts @kubernetes/release-managers?
There was a problem hiding this comment.
Please refer the discussion in the 1.29 cherry-pick PR #123693 (review)
saschagrunert
approved these changes
Mar 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani, mengqiy, saschagrunert, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/triage accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #123532 on release-1.28.
#123532: Prevent watch cache starvation, by moving its watch to
For details on the cherry pick process, see the cherry pick requests page.