codegen: don't nuke files if only verifying #123261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code generation tools support verification only with the --verify-only option, but this now fails because the files are nuked ahead of time. Signed-off-by: Stephen Kitt <[email protected]>
|
/cc @thockin This breaks external projects using |
skitt
added a commit
to skitt/submariner-addon
that referenced
this pull request
Feb 13, 2024
This reverts commit 6fb8a12. kube_codegen.sh only defines functions, generate-groups.sh still needs to be called to actually perform the generation. generate-groups.sh relies on generate-internal-groups.sh which needs to be made executable. The latter also nukes generated files even when verifying; this is disabled here by modifying the vendored files. See kubernetes/kubernetes#123261 for the proposed upstream fix. Signed-off-by: Stephen Kitt <[email protected]>
openshift-merge-bot bot
pushed a commit
to stolostron/submariner-addon
that referenced
this pull request
Feb 13, 2024
This reverts commit 6fb8a12. kube_codegen.sh only defines functions, generate-groups.sh still needs to be called to actually perform the generation. generate-groups.sh relies on generate-internal-groups.sh which needs to be made executable. The latter also nukes generated files even when verifying; this is disabled here by modifying the vendored files. See kubernetes/kubernetes#123261 for the proposed upstream fix. Signed-off-by: Stephen Kitt <[email protected]>
|
generate-groups.sh is deprecated and will be nuked entirely when Go workspaces lands, as will the verify logic (I honestly didn't think anyone used it at all). I could maybe see restoring the verify functionality post-workspaces, maybe. |
|
I'll approve for the purpose of backporting, but if I get my way this is all removed in 30. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: cbd89a28672fd01a967126ea092244963508fe1d
|
This was referenced Feb 19, 2024
|
/triage accepted |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 1, 2024
…1-origin-release-1.29 Automated cherry pick of #123261: codegen: don't nuke files if only verifying
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 1, 2024
…1-origin-release-1.28 Automated cherry pick of #123261: codegen: don't nuke files if only verifying
skitt
added a commit
to skitt/open-cluster-management-api
that referenced
this pull request
May 28, 2024
This file removal bug was fixed by kubernetes/kubernetes#123261 Signed-off-by: Stephen Kitt <[email protected]>
skitt
added a commit
to skitt/open-cluster-management-api
that referenced
this pull request
May 28, 2024
This file removal bug was fixed by kubernetes/kubernetes#123261 so the workaround can be removed. Signed-off-by: Stephen Kitt <[email protected]>
openshift-merge-bot bot
pushed a commit
to open-cluster-management-io/api
that referenced
this pull request
May 29, 2024
This file removal bug was fixed by kubernetes/kubernetes#123261 so the workaround can be removed. Signed-off-by: Stephen Kitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
The code generation tools support verification only with the --verify-only option, but this now fails because the files are nuked ahead of time.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: