-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #123077: kubeadm: better checks if the node is CP during "upgrade #123097
Automated cherry pick of #123077: kubeadm: better checks if the node is CP during "upgrade #123097
Conversation
Currently --rootfs does not work with "upgrade node" for CP nodes because the only check of CP nodes is performed in newNodeOptions() which runs before the root kubeadm command is run, thus the chroot() path coming from --rootfs is not applied yet. To work around that call the "isControlPlaneNode" check when constructing the command data on command runtime.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/tirage accepted |
/lgtm |
LGTM label has been added. Git tree hash: e215bd6b5cd2b6b8bf58e8fe5e01b65c2514c351
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, saschagrunert, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-node-e2e-containerd |
/retest |
1 similar comment
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Cherry pick of #123077 on release-1.28.
#123077: kubeadm: better checks if the node is CP during "upgrade
For details on the cherry pick process, see the cherry pick requests page.