Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of #123003 and #123082: bugfix: dont skip reconcile for unchanged policy if last sync #123080

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Cherry pick of #123003 and #123082: bugfix: dont skip reconcile for unchanged policy if last sync #123080

merged 2 commits into from
Feb 9, 2024

Conversation

alexzielenski
Copy link
Contributor

@alexzielenski alexzielenski commented Feb 1, 2024 •
edited

Cherry pick of #123003 and #123082 on release-1.29.

#123003: bugfix: dont skip reconcile for unchanged policy if last sync
#123082: test: remove unnecessary skip healthz check from test

For details on the cherry pick process, see the cherry pick requests page.

Fixed a bug in ValidatingAdmissionPolicy that caused policies which were using CRD parameters to fail to synchronize

I think this is a very low risk but impactful bugfix for VAP which is in beta but not enabled by default in 1.29.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2024
@alexzielenski
Copy link
Contributor Author

seems to be a problem cleaning up goroutines in the new test (which Runs StartTestServer, closes it, then runs it again)

@alexzielenski
test: remove unnecessary skip healthz check from test
6ff7551 
snuck in there while I was working on the test, but is ultimately not necessary to test the functionality.

skipping healthz check resulted in leaking goroutines from poststarthooks.
@Cajga
Copy link

Cajga commented Feb 5, 2024

@alexzielenski would love to get this back-port. The bug makes VAP in 1.29 basically useless with CRDs. Can we help somehow to push this forward?

@tobiasgiese tobiasgiese mentioned this pull request Feb 5, 2024
Closed
@alexzielenski alexzielenski changed the title Automated cherry pick of #123003: bugfix: dont skip reconcile for unchanged policy if last sync Cherry pick of #123003 and #123082: bugfix: dont skip reconcile for unchanged policy if last sync Feb 5, 2024
@cici37
Copy link
Contributor

cici37 commented Feb 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c13e8fadda266b0216b20dc78c4c7c5cc7c51f01

@cici37 cici37 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 7, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 7, 2024
@cici37 cici37 added the kind/bug Categorizes issue or PR as related to a bug. label Feb 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 7, 2024
@cici37
Copy link
Contributor

cici37 commented Feb 7, 2024

@kubernetes/release-managers Would you please approve it when have time? Thank you :)

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3
Copy link
Contributor

seans3 commented Feb 8, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2024
@alexzielenski
Copy link
Contributor Author

/retest

@alexzielenski
Copy link
Contributor Author

/retest

CI having docker issues?

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit b39bf52 into kubernetes:release-1.29 Feb 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@jpbetz jpbetz Awaiting requested review from jpbetz

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alexzielenski @Cajga @cici37 @k8s-ci-robot @seans3 @k8s-triage-robot @saschagrunert