Fix cleanup of file subpaths #123052
Merged
Fix cleanup of file subpaths #123052
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow kubelet orphan cleanup to delete both files and empty directories as subpath mount points. A pod does not need to use a directory as a subpath, it can use a file (unix domain socket, pipe, ...) too. Therefore the cleanup should use `os.Remove` that deletes both files and empty directories.
|
/triage accepted |
|
cc @dobsonj |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4d8f85c38881cc01b861922362f50c8d9135d2d8
|
mrunalp
approved these changes
Feb 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 12, 2024
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 1, 2024
…3052-upstream-release-1.29 Automated cherry pick of #123052: Fix cleanup of file subpaths
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 1, 2024
…3052-upstream-release-1.27 Automated cherry pick of #123052: Fix cleanup of file subpaths
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 1, 2024
…3052-upstream-release-1.28 Automated cherry pick of #123052: Fix cleanup of file subpaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Allow kubelet orphan cleanup to delete both files and empty directories used as subpath mount points.
A pod does not need to use a directory as a subpath, it can use a file (unix domain socket, pipe, ...) too. Therefore the cleanup should use
os.Removethat deletes both files and empty directories.This contrasts with whole volumes - a volume is always a directory.
Which issue(s) this PR fixes:
Fixes: #106942
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: