Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process_start_time_seconds to metrics/slis endpoint for all components #122750

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add process_start_time_seconds to metrics/slis endpoint for all components #122750

merged 1 commit into from
Jan 25, 2024

Conversation

richabanker
Copy link
Contributor

@richabanker richabanker commented Jan 12, 2024 •
edited

Fixes #122520

Special notes for your reviewer:

Add process_start_time_seconds to /metrics/slis endpoint of all components

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

# HELP process_start_time_seconds [ALPHA] Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.70509226673e+09

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
logicalhan
logicalhan approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2024
@pacoxu
Copy link
Member

pacoxu commented Jan 13, 2024 

{ ScriptError 
staging/src/k8s.io/component-base/metrics/prometheus/slis/metrics.go:22:2: ST1019: package "k8s.io/component-base/metrics" is being imported more than once (stylecheck)
	compbasemetrics "k8s.io/component-base/metrics"
	^
staging/src/k8s.io/component-base/metrics/prometheus/slis/metrics.go:23:2: ST1019(related information): other import of "k8s.io/component-base/metrics" (stylecheck)
	k8smetrics "k8s.io/component-base/metrics"
	^
}

CI failure needs to be fixed.

/kind feature
/lgtm cancel

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 13, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2024
@richabanker richabanker force-pushed the metrics-slis-test branch 2 times, most recently from 552d175 to a216ca6 Compare January 13, 2024 18:43
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2024
dgrisonnet
dgrisonnet approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00bef8617c9dc26a21757c5f65f4601ebd11d40e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, logicalhan, Richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7f1ea6 into kubernetes:master Jan 25, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 25, 2024
This was referenced Jan 31, 2024
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2024
@k8s-ci-robot
Merge pull request #123063 from Richabanker/automated-cherry-pick-of-…
68d7e46 
…#122750-upstream-release-1.27

Automated cherry pick of #122750: Add processStartTime in metrics/slis
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2024
@k8s-ci-robot
Merge pull request #123065 from Richabanker/automated-cherry-pick-of-…
f6b2ccb 
…#122750-upstream-release-1.29

Automated cherry pick of #122750: Add processStartTime in metrics/slis
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2024
@k8s-ci-robot
Merge pull request #123062 from Richabanker/automated-cherry-pick-of-…
34fddee 
…#122750-upstream-release-1.26

Automated cherry pick of #122750: Add processStartTime in metrics/slis
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2024
@k8s-ci-robot
Merge pull request #123064 from Richabanker/automated-cherry-pick-of-…
e9883fa 
…#122750-upstream-release-1.28

Automated cherry pick of #122750: Add processStartTime in metrics/slis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@logicalhan logicalhan

@pacoxu pacoxu

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

Metric process_start_time_seconds is not defined for /metrics/slis
5 participants
@richabanker @k8s-ci-robot @pacoxu @logicalhan @dgrisonnet