Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #122346: Make OpenAPIGetter tolerant of nil #122559

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Automated cherry pick of #122346: Make OpenAPIGetter tolerant of nil #122559

merged 1 commit into from
Jan 10, 2024

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Jan 2, 2024 •
edited

Cherry pick of #122346 on release-1.29.

#122346: Make OpenAPIGetter tolerant of nil

For details on the cherry pick process, see the cherry pick requests page.

Fix an issue where kubectl apply could panic when imported as a library

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 2, 2024
@Jefftree
Copy link
Member Author

Jefftree commented Jan 2, 2024

/assign @ardaguclu
/cc @tomasaschan

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

@Jefftree: GitHub didn't allow me to request PR reviews from the following users: tomasaschan.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @ardaguclu
/cc @tomasaschan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 2, 2024
tomasaschan
tomasaschan approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@tomasaschan tomasaschan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval doesn't count, but might help others review I guess.

@tomasaschan
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tomasaschan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member

/triage accepted
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e9c436e0a5410ac75b55cae332fa27c73a4f1b67

@ardaguclu
Copy link
Member

/kind regression

@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 3, 2024
@Jefftree
Copy link
Member Author

Jefftree commented Jan 3, 2024

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team January 3, 2024 18:39
@xmudrii
Copy link
Member

xmudrii commented Jan 10, 2024

@Jefftree Is this issue affecting only kubectl v1.29 or are earlier versions affected as well?

xmudrii
xmudrii approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, Jefftree, tomasaschan, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 73b4bf2 into kubernetes:release-1.29 Jan 10, 2024
16 checks passed
@Jefftree
Copy link
Member Author

@xmudrii Only affecting 1.29

@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasaschan tomasaschan tomasaschan approved these changes

@xmudrii xmudrii xmudrii approved these changes

@seans3 seans3 Awaiting requested review from seans3

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ardaguclu ardaguclu

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Archived in project
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jefftree @k8s-ci-robot @tomasaschan @ardaguclu @xmudrii @liggitt