Fix CSI migration for vSphere volumes #122341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore `migratedPlugins` entry for in-tree vSphere volumes and mark them as migrated. Otherwise the CSI volume plugin ignores in-tree vSphere volumes and they will never get attached / mounted by CSI migration. The entry in `migratedPlugins` was incorrectly removed during CSIMigrationvSphere feature gate removal.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/priority important-soon |
|
/triage accepted |
|
lgtm but want to hear from either @xing-yang or @divyenpatel /lgtm |
|
LGTM label has been added. Git tree hash: 1bab9c0cf957237a97a164d3d8145b4fbc849172
|
|
/assign @divyenpatel |
|
/lgtm |
|
I am going to remove the hold though. I think this PR makese sense. /hold cancel |
|
/cherry-pick release-1.29 |
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 21, 2023
…2341-upstream-release-1.29 Automated cherry pick of #122341: Fix CSI migration for vSphere volumes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Restore
migratedPluginsentry for in-tree vSphere volumes and mark them as migrated. Otherwise the CSI volume plugin ignores in-tree vSphere volumes and they will never get attached / mounted by CSI migration.The entry in
migratedPluginswas incorrectly removed during CSIMigrationvSphere feature gate removal.Which issue(s) this PR fixes:
Fixes #122340
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: