Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump runc to v1.1.10 #121739

Merged
merged 1 commit into from
Nov 15, 2023
Merged

bump runc to v1.1.10 #121739

merged 1 commit into from
Nov 15, 2023

Conversation

ty-dc
Copy link
Member

@ty-dc ty-dc commented Nov 6, 2023 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

In the changelog for runc v1.1.10, the following is mentioned:

This is the tenth (and most likely final) patch release in the 1.1.z
release branch of runc. It mainly fixes a few issues in cgroups, and a
umask-related issue in tmpcopyup.

So, this PR is for updating github.com/opencontainers/runc to v1.1.10.

Which issue(s) this PR fixes:
Fixes # None

Special notes for your reviewer:

Updated `runc` (used as a Go library) to v1.1.10

@ty-dc
bump runc to v1.1.10
bb315d1 
Signed-off-by: tao.yang <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Nov 6, 2023
@pacoxu
Copy link
Member

pacoxu commented Nov 6, 2023

/sig node
/cc @mrunalp @SergeyKanzhelev @dims

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2023
@pacoxu
Copy link
Member

pacoxu commented Nov 6, 2023

/sig architecture
/area code-organization

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/code-organization Issues or PRs related to kubernetes code organization labels Nov 6, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Nov 7, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Nov 10, 2023

@ty-dc please, provide release notes, thanks
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 10, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Nov 10, 2023
@pacoxu
Copy link
Member

pacoxu commented Nov 13, 2023

/lgtm
/assign @dims @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: efebc97c9543fcfceb26a1e00c801f9a988e298c

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 13, 2023
@liggitt
Copy link
Member

liggitt commented Nov 13, 2023

assigning node folks for a first pass
/assign @mrunalp @SergeyKanzhelev

it's not clear (to me) what the priority and risk level is here, if this should go in for 1.29 or wait for master to reopen for 1.30

@pacoxu
Copy link
Member

pacoxu commented Nov 13, 2023

#120813 this may be fixed by this upgrade.

@SergeyKanzhelev may know the context.

@SergeyKanzhelev
Copy link
Member

This was discussed among SIG Node leads and we believe this is low risk, but important fix and we want to get an exception to take it for 1.29

/milestone 1.29
/priority critical-urgent

Applying critical-urgent to indicate we want it for 1.29 release.

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.24, v1.25, v1.26, v1.27, v1.28, v1.29, v1.30]

Use /milestone clear to clear the milestone.

In response to this:

This was discussed among SIG Node leads and we believe this is low risk, but important fix and we want to get an exception to take it for 1.29

/milestone 1.29
/priority critical-urgent

Applying critical-urgent to indicate we want it for 1.29 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 15, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 15, 2023
@dims
Copy link
Member

dims commented Nov 15, 2023

/approve
/hold for @kubernetes/release-team-leads @Priyankasaggu11929

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mrunalp, ty-dc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@Priyankasaggu11929
Copy link
Member

per #121739 (comment)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 56d7898 into kubernetes:master Nov 15, 2023
15 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Nov 15, 2023
@sftim
Copy link
Contributor

sftim commented Nov 24, 2023

Release note suggestion:

-Update runc to 1.1.10
+Updated `runc` (used as a Go library) to 1.1.10

@ehashman ehashman mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@logicalhan logicalhan Awaiting requested review from logicalhan

@dims dims Awaiting requested review from dims

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@dims dims

@mrunalp mrunalp

@liggitt liggitt

@pacoxu pacoxu

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ty-dc @pacoxu @bart0sh @k8s-ci-robot @liggitt @SergeyKanzhelev @dims @Priyankasaggu11929 @sftim @mrunalp