Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote SidecarContainers feature to beta #121579

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Promote SidecarContainers feature to beta #121579

merged 1 commit into from
Oct 31, 2023

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Oct 28, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This promotes the SidecarContainers feature to beta.
#120620: The main change is that sidecar termination is serialized.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The SidecarContainers feature has graduated to beta and is enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/753-sidecar-containers

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 28, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 28, 2023
@gjkim42 gjkim42 changed the title [DO NOT MERGE] Promote SidecarContainers feature to beta [WIP] [DO NOT MERGE] Promote SidecarContainers feature to beta Oct 28, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2023
@gjkim42 gjkim42 changed the title [WIP] [DO NOT MERGE] Promote SidecarContainers feature to beta Promote SidecarContainers feature to beta Oct 31, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 31, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented Oct 31, 2023

/sig node
/priority important-soon
/kind feature

/assign @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 31, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented Oct 31, 2023

/cc @matthyx @tzneal

tzneal
tzneal approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Holding pending outcome of SIG Node discussion today.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca54c1c9f811d04054fc8f69fc9513e725618a80

@tzneal
Copy link
Contributor

tzneal commented Oct 31, 2023

/unhold

No objections from SIG Node

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@dims
Copy link
Member

dims commented Oct 31, 2023

/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 31, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

as discussed at SIG Node meeting today we changed scope of KEP a bit and this is good to go now

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjkim42, SergeyKanzhelev, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 84aca4a into kubernetes:master Oct 31, 2023
13 of 15 checks passed
@gjkim42 gjkim42 deleted the test-enable-sidecarcontainers branch October 31, 2023 22:50
@npolshakova npolshakova mentioned this pull request Nov 1, 2023
Open
11 tasks
@Rei1010 Rei1010 mentioned this pull request Dec 1, 2023
Merged
@nathanmcgarvey-modopayments nathanmcgarvey-modopayments mentioned this pull request Jan 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@tzneal tzneal

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gjkim42 @k8s-ci-robot @tzneal @dims @SergeyKanzhelev