Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: Build image 3.5.10 #121567

Merged
merged 1 commit into from
Oct 27, 2023
Merged

etcd: Build image 3.5.10 #121567

merged 1 commit into from
Oct 27, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Oct 27, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Build Image for v3.5.10.

Which issue(s) this PR fixes:
Fixes NONE #

Does this PR introduce a user-facing change?:

NONE

etcd: build image for v3.5.10

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 27, 2023
@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 43015efbfd828f4d2e8b2abaa0177eafc5d3526d

@mzaian
Copy link
Contributor Author

mzaian commented Oct 27, 2023

/retest

@dims
Copy link
Member

dims commented Oct 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mzaian, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 956b5ad into kubernetes:master Oct 27, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 27, 2023
@mzaian mzaian mentioned this pull request Oct 27, 2023
Merged
@mzaian
Copy link
Contributor Author

mzaian commented Oct 28, 2023

Hello @serathius and @dims

I think it failed to build and push the image after merging. I'm unable to pull the image and blocked on
#121566
kubernetes/k8s.io#6032

@dims
Copy link
Member

dims commented Oct 28, 2023

I started another run, let's see how that goes: https://prow.k8s.io/?job=post*etcd

@pacoxu pacoxu mentioned this pull request Oct 30, 2023
Merged
@mzaian
Copy link
Contributor Author

mzaian commented Oct 30, 2023

I started another run, let's see how that goes: https://prow.k8s.io/?job=post*etcd

Still failing :(

@mzaian mzaian mentioned this pull request Oct 30, 2023
Closed
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mzaian @serathius @k8s-ci-robot @dims @leilajal