Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CSINodeExpandSecret to GA #121303

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Promote CSINodeExpandSecret to GA #121303

merged 2 commits into from
Nov 1, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Oct 17, 2023 •
edited

This feature is in Beta since 1.27 and this has been promoted to GA in this release.

KEP: kubernetes/enhancements#4239

Reference # kubernetes/enhancements#4239

What type of PR is this?

/kind feature

-->

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CSINodeExpandSecret feature has been promoted to GA in this release and enabled by default. The CSI drivers can make use of the `secretRef` values passed in NodeExpansion request optionally sent by the CSI Client from this release onwards.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/regression Categorizes issue or PR as related to a regression from a prior release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 17, 2023
@humblec
Copy link
Contributor Author

humblec commented Oct 17, 2023

cc @xing-yang

swatisehgal
swatisehgal reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few place where we have checks to determine if this feature gate is enabled or not and we need to remove those as the feature gate is locked to default. Here are a few examples:

kubernetes/pkg/volume/csi/expander.go

Line 86 in d22e315

if utilfeature.DefaultFeatureGate.Enabled(features.CSINodeExpandSecret) {

kubernetes/pkg/api/persistentvolume/util.go

Line 37 in 64799e0

if !utilfeature.DefaultFeatureGate.Enabled(features.CSINodeExpandSecret) && !hasNodeExpansionSecrets(oldPVSpec) {

kubernetes/pkg/volume/csi/expander_test.go

Line 120 in 64799e0

defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSINodeExpandSecret, tc.enableCSINodeExpandSecret)()

kubernetes/pkg/api/persistentvolume/util_test.go

Line 92 in 64799e0

defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSINodeExpandSecret, tc.csiExpansionEnabled)()

pkg/features/kube_features.go Outdated Show resolved Hide resolved
@Shubham82 Shubham82 mentioned this pull request Oct 18, 2023
Merged
@xing-yang
Copy link
Contributor

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 20, 2023
@xing-yang
Copy link
Contributor

xing-yang commented Oct 25, 2023 •
edited

Comments for the API needs to be updated from "beta" to "GA":
https://github.com/kubernetes/kubernetes/blob/v1.29.0-alpha.2/pkg/apis/core/types.go#L1808

@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Oct 27, 2023
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 31, 2023
@msau42
Copy link
Member

msau42 commented Oct 31, 2023

/lgtm
/approve

@msau42
Copy link
Member

msau42 commented Oct 31, 2023

/remove-kind failing-test
/remove-kind regression

@k8s-ci-robot k8s-ci-robot removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Oct 31, 2023
@msau42
Copy link
Member

msau42 commented Oct 31, 2023

/remove-kind deprecation

@k8s-ci-robot k8s-ci-robot removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Oct 31, 2023
@msau42
Copy link
Member

msau42 commented Oct 31, 2023

/remove-kind flake

@k8s-ci-robot k8s-ci-robot removed the kind/flake Categorizes issue or PR as related to a flaky test. label Oct 31, 2023
@humblec
Copy link
Contributor Author

humblec commented Oct 31, 2023

@wojtek-t can you please review/approve it from registry/owners side ?

@msau42
Copy link
Member

msau42 commented Oct 31, 2023

Trying to get #121210 merged

@msau42
Copy link
Member

msau42 commented Oct 31, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@dims
Copy link
Member

dims commented Oct 31, 2023

@humblec please rebase!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2023
@humblec @zhucan
Promote CSINodeExpandSecret to GA
77f4178 
This feature is in Beta since 1.27 and this has been promoted
to GA in this release.

KEP: kubernetes/enhancements#4239

Signed-off-by: Humble Chirammal <[email protected]>
@humblec
Update APIs and adjust tests
3890546 
Signed-off-by: zhucan <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2023

@xing-yang @msau42 rebased to master to resolve the conflict.. can you please bring back lgtm ?

@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2023

@humblec please rebase!

sure, done @dims

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fec0ae6665df0a7dcc5aba936318c41520a70686

@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit d038b65 into kubernetes:master Nov 1, 2023
19 checks passed
@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2023

Thanks everyone 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin Awaiting requested review from thockin

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@xing-yang xing-yang Awaiting requested review from xing-yang

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@msau42 msau42 Awaiting requested review from msau42

Assignees

@xing-yang xing-yang

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@humblec @xing-yang @zhucan @dims @MaryamTavakkoli @k8s-ci-robot @msau42 @swatisehgal