Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate the kubeProxyVersion field of v1.Node #120954

Merged
merged 1 commit into from
Oct 31, 2023
Merged

deprecate the kubeProxyVersion field of v1.Node #120954

merged 1 commit into from
Oct 31, 2023

Conversation

HirazawaUi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Deprecate the status.nodeInfo.kubeProxyVersion field of v1.Node, this field is not accurate, it is set by kubelet, which does not actually know the kube-proxy version, or even if kube-proxy is running.

Which issue(s) this PR fixes:

Fixes #117756

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add the DisableNodeKubeProxyVersion feature gate. If DisableNodeKubeProxyVersion is enabled, the kubeProxyVersion field is not set.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 1, 2023
@HirazawaUi HirazawaUi force-pushed the deprecate-kubeProxyVersione-field branch from d06d81a to 1bf35ea Compare October 1, 2023 08:19
@HirazawaUi HirazawaUi mentioned this pull request Oct 1, 2023
Open
9 tasks
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Oct 1, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Oct 1, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 1, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Oct 1, 2023
@HirazawaUi HirazawaUi force-pushed the deprecate-kubeProxyVersione-field branch from 1bf35ea to b5d8cbe Compare October 1, 2023 16:59
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 1, 2023
@HirazawaUi HirazawaUi force-pushed the deprecate-kubeProxyVersione-field branch from b5d8cbe to 20e5c95 Compare October 1, 2023 18:31
@HirazawaUi HirazawaUi mentioned this pull request Oct 6, 2023
Merged
@HirazawaUi
Copy link
Contributor Author

/cc @danwinship

@HirazawaUi HirazawaUi force-pushed the deprecate-kubeProxyVersione-field branch from 4d906c4 to c9afedf Compare October 16, 2023 15:08
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@HirazawaUi HirazawaUi force-pushed the deprecate-kubeProxyVersione-field branch from c9afedf to 50a9d72 Compare October 21, 2023 14:11
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2023
@HirazawaUi
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@danwinship
Copy link
Contributor

/lgtm
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a377354e9432c418617b3f2d8010cb4663b18313

@thockin thockin mentioned this pull request Oct 24, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
@HirazawaUi HirazawaUi force-pushed the deprecate-kubeProxyVersione-field branch from 50a9d72 to 2c2fa21 Compare October 29, 2023 07:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2023
@danwinship
Copy link
Contributor

/lgtm
(just rebased around other pkg/features conflicts)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c0939a1c58053dbe7586f43f24101f2d848c3d0

@HirazawaUi
Copy link
Contributor Author

@thockin May you approve it? The code will be freeze tomorrow at 1:00

thockin
thockin reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@thockin
Copy link
Member

thockin commented Oct 31, 2023

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit d475c24 into kubernetes:master Oct 31, 2023
15 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Oct 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@cyclinder cyclinder cyclinder left review comments

@liggitt liggitt Awaiting requested review from liggitt

@rphillips rphillips Awaiting requested review from rphillips

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@danwinship danwinship

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

node.status.nodeInfo.kubeProxyVersion is a lie
7 participants
@HirazawaUi @bart0sh @danwinship @k8s-ci-robot @thockin @liggitt @cyclinder