Fix issue in enabling evented pleg feature gate #120942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e |
|
/test |
|
@harche: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ? |
|
@harche: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-node-crio-e2e |
|
/test pull-kubernetes-unit |
|
/triage accepted |
mrunalp
approved these changes
Oct 18, 2023
|
LGTM label has been added. Git tree hash: d98d6946b263b93e14f64523538f26caf51a0f6a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, sairameshv, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubernetes-e2e-kind |
|
also fixes #121349 |
|
Should we cherry-pick it to v1.26~v1.28? @sairameshv @saschagrunert |
|
Yes, I'd be in favor of that. 👍 |
|
@sairameshv may I ask you to edit the release note section to be a bit more concrete? |
This was referenced Oct 19, 2023
|
KEP xref: kubernetes/enhancements#3386 |
The failing test in https://testgrid.k8s.io/presubmits-kubernetes-nonblocking#pull-kubernetes-e2e-kind-alpha-features&width=90 is not fixed. FYI. But currently, I still do not confirm if this is related to this issue. There are other failures there. |
@pacoxu , I'm trying to actually figure out the issue from the e2e periodic job failures. But unfortunately, I couldn't find the related kubelet logs from the job artifacts(Ex: evented-pleg job) |
|
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/121477/pull-kubernetes-e2e-kind-beta-features/1719488708551380992 is a general run that is based on #121477.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/121345/pull-kubernetes-e2e-kind-beta-features/1719259096076521472 is a run with disabled Evented PLGE FG.
|
22 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
After enabling the evented pleg feature gate in the kubelet,
SyncLoop ADD/UPDATE/RECONCILEfunctions are executed multiple times in a very less time interval, the Kubelet calls multipleCreateContainerCRI apis that results in the creation of duplicate containers within a given pod.Runningand the later container keepsExitingand hence resulting the pod inCrashLoopBackOffstate forever.Which issue(s) this PR fixes:
Fixes #120941 #120140 #121003
Does this PR introduce a user-facing change?