Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cloud-provider/cloud-config in apiserver CLI #120903

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Deprecate cloud-provider/cloud-config in apiserver CLI #120903

merged 1 commit into from
Sep 28, 2023

Conversation

dims
Copy link
Member

@dims dims commented Sep 26, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Related to #49402 not sure why we missed deprecating it a while ago!

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Deprecated the `--cloud-provider` and `--cloud-config` CLI parameters in kube-apiserver.
These parameters will be removed in a future release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 26, 2023
@dims
Copy link
Member Author

dims commented Sep 26, 2023

/sig api-machinery
/assign @liggitt @deads2k @andrewsykim

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@alexzielenski
Copy link
Contributor

/triage accepted

@dims dims force-pushed the deprecate-cloud-provider-and-config-cli-params branch from e598c7a to 4d2d994 Compare September 26, 2023 20:05
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 26, 2023
@dims
Copy link
Member Author

dims commented Sep 27, 2023

@liggitt here's proof that kube-apiserver does not need either cloud-provider or cloud-config:
9b91255

The situation mentioned in #49402 w.r.t PersistentVolumeLabel is still true. that's the ONLY thing that needs these 2 parameters.

the current plan is for https://github.com/kubernetes-sigs/cloud-pv-admission-labeler to take over from that admission controller. Note that PersistentVolumeLabel admission controller is already marked as deprecated as well.

@liggitt
Copy link
Member

liggitt commented Sep 28, 2023 •
edited

/lgtm
/approve

worth noting for anyone wanting to copy this for other --cloud-provider flags in kubelet or kube-controller-manager that --cloud-provider=external continues to be necessary / valid for those components, so we wouldn't mark those flags as deprecated.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a3e822cc694202b9d5110e51510b8b76bc9d228e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 26c3f66 into kubernetes:master Sep 28, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 28, 2023
@sftim
Copy link
Contributor

sftim commented Oct 9, 2023

Changelog suggestion

Deprecated the `--cloud-provider` and `--cloud-config` CLI parameters in kube-apiserver.
These parameters will be removed in a future release.

@dims
Copy link
Member Author

dims commented Oct 9, 2023

Updated with your suggestion @sftim thanks!

@liggitt liggitt mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@deads2k deads2k

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dims @alexzielenski @liggitt @k8s-ci-robot @sftim @deads2k @andrewsykim