reintroduce resourcequota.NewMonitor #120777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this function is used by other packages and was mistakenly removed in 397cc73 - let resource quota controller use this constructor instead of an object instantiation
This was referenced Sep 20, 2023
|
Thanks, but as #115103 (comment) , we do not guarantee compatibility of internal packages! Perhaps we can also look at @thockin's thoughts on the issue. |
It's not as easy as the issue claims, and there will be cases where we'll continue keeping those functions as is. |
|
LGTM label has been added. Git tree hash: e3f9cf7e529c2046a4da8eb10626ed27c30111d3
|
|
/triage accepted |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test pull-kubernetes-node-e2e-containerd |
@atiratree Do you have time to create the cherry-pick PR to v1.28 for this regression? |
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 21, 2023
…20777-upstream-release-1.28 Automated cherry pick of #120777: reintroduce resourcequota.NewMonitor
|
FWIW, this was not a regression. Stability of go functions / signatures in k8s.io/kubernetes aren't part of the API surface area we guarantee. |
|
Agree emphatically - we do not support people importing from within k8s.io/kubernetes and any project that depends on it may find themselves on the receiving end of such a cleanup. |
|
ack, thanks for removing the regression part |
dhellmann
added a commit
to dhellmann/microshift
that referenced
this pull request
Oct 6, 2023
dhellmann
added a commit
to dhellmann/microshift
that referenced
this pull request
Oct 10, 2023
openshift-ci bot
pushed a commit
to openshift/microshift
that referenced
this pull request
Oct 13, 2023
* update last_rebase.sh * update changelog * update microshift/go.mod * update microshift/vendor * update etcd/go.mod * update etcd/vendor * update component images * update manifests * update buildfiles * add patch to reintroduce resourcequota.NewMonitor See kubernetes/kubernetes#120777 * apply resourcequota.NewMonitor patch * update location of ServiceIPRange The definition of ServiceIPRange changed in upstream kubernetes, so update the way we import it. * remove trailing whitespace in build_images.sh * USHIFT-1638: fix current release package source template At the start of a release cycle there are no EC or RC builds for the current release, so we should skip adding the package source. Package sources are skipped if their template produces an empty file when rendered. The crel template was producing a file with 1 blank line. Fix the whitespace marker at the end of the template to avoid an extra blank line. * USHIFT-1638: fix detection of empty blueprint file Use the right local variable for the file to check for content to detect that a template for a blueprint rendered empty. * when crd manager receives cancel notice return the error * USHIFT-1638: allow repeated configuration of logging Tell the logging code that it's OK to receive reconfiguration instructions unless those instructions are different. This overrides the default behavior of erroring out if any instructions are received a second time. That default behavior causes issues with embedded components that all use the same logging code and are not expecting to be compiled together into the same process, as they are in MicroShift. See comments in k8s.io/component-base/logs/api/v1/options.go for details. --------- Co-authored-by: ci-robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
After bumping kubernetes dependencies, other projects depending on this public constructor will fail to compile. E.g. openshift/cluster-policy-controller#132. Since the QuotaMonitor members are private, there is no workaround.
Special notes for your reviewer:
This PR should be backported to 1.28 for compatibility reasons.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: