Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a wider-range of metric buckets for PodStartDuration #120680

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Use a wider-range of metric buckets for PodStartDuration #120680

merged 1 commit into from
Oct 25, 2023

Conversation

ruiwen-zhao
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Current max bucket for PodStartDuration is 10 seconds, which is not enough for the metric PodStartDuration, which spans from pod scheduling to pod starting. (Note that image pulling time is included in PodStartDuration).

This PR changes the bucket to the same as PodStartSLIDuration.

Similar effort has been done on RuntimeOperationsDuration metric in #96054

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Metric buckets for pod_start_duration_seconds are changed to {0.5, 1, 2, 3, 4, 5, 6, 8, 10, 20, 30, 45, 60, 120, 180, 240, 300, 360, 480, 600, 900, 1200, 1800, 2700, 3600}

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2023
@ruiwen-zhao
Copy link
Contributor Author

/sig instrumentation
/sig node
/cc @qiutongs

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Sep 14, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Sep 15, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Sep 20, 2023

/retest

@dashpole
Copy link
Contributor

/triage accepted
/assign @dgrisonnet

We should ideally use exponential buckets instead of manually setting boundaries: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/metrics/buckets.go#L32

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 21, 2023
@dashpole
Copy link
Contributor

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 21, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, ruiwen-zhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@qiutongs
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd1fde866090d8d441c714a5a7215fb2697f1226

@k8s-ci-robot k8s-ci-robot merged commit f82670d into kubernetes:master Oct 25, 2023
14 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@qiutongs qiutongs Awaiting requested review from qiutongs

@sjenning sjenning Awaiting requested review from sjenning

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@qiutongs qiutongs

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ruiwen-zhao @bart0sh @dashpole @k8s-ci-robot @qiutongs @mrunalp @dgrisonnet