Mark a volume as uncertain-attached after detach error #120595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volume that failed Detach() should not be marked as attached, CSI external-attacher is probably still trying to detach it. Mark it uncertain instead and wait for Detach() to succeed.
e974879
to
7fc11f4
Compare
kvaps
approved these changes
Oct 4, 2023
|
/assign @jingxu97 |
|
I was mainly checking the case mentioned here, to make sure it won't cause issue like volume is never reported as attached again. Since uncertain should always trigger attach operation, which will make a call of AddVolumeToReportAsAttached, I don't think there is an issue. Overall I think it is safer to mark volume as uncertain when there is a failure, especially when we don't know it is transient or not. Thanks @jsafrane for the great analysis of this tricky issue and provide the fix. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 3221fd9de0bb548b316747c7d6c5b8aa20d3e42e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, jsafrane, kvaps The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/priority important-soon |
This was referenced Oct 9, 2023
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 12, 2023
…0595-upstream-release-1.26 Automated cherry pick of #120595: Mark a volume as uncertain-attached after detach error
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 12, 2023
…0595-upstream-release-1.27 Automated cherry pick of #120595: Mark a volume as uncertain-attached after detach error
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 12, 2023
…0595-upstream-release-1.28 Automated cherry pick of #120595: Mark a volume as uncertain-attached after detach error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
A volume that failed
Detach()should not be marked as attached, CSI external-attacher is probably still trying to detach it.Mark it uncertain instead and wait for
Detach()to succeed. I updated an existing unit test for it.Which issue(s) this PR fixes:
Fixes #120571
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: