-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: fix metric container_start_time_seconds
timestamp
#120518
kubelet: fix metric container_start_time_seconds
timestamp
#120518
Conversation
/test pull-kubernetes-node-crio-e2e |
if t.Unix() <= 0 { | ||
return time.Now() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dashpole PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adapting the tests and reverting kubernetes#103429 Carry-over from kubernetes#117881 Signed-off-by: Sascha Grunert <[email protected]>
3ede6ef
to
5e09313
Compare
/test pull-kubernetes-node-crio-e2e |
container_start_time_seconds
timestamp
/triage accepted |
/sig instrumentation /assign @dashpole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 899352a96bfa6441c80e6fb68b183870a2b1a212
|
/assign @mrunalp @dchen1107 @derekwaynecarr |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, dims, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adapting the tests and reverting #103429
Carry-over from #117881
Which issue(s) this PR fixes:
Fixes #117880
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: