The committers listed above are authorized under a signed CLA.

• ✅ login: fengxsong / name: fengxsong (a69f56e)

Welcome @fengxsong!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @fengxsong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

can you please show some output from your terminal? why is this happening, is it because of a different systemctl version?

@neolit123

➜  sealos git:(main) cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.6 LTS"
➜  sealos git:(main) systemctl --version
systemd 245 (245.4-4ubuntu3.22)
+PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2 default-hierarchy=hybrid
➜  sealos git:(main) systemctl status noneexists
Unit noneexists.service could not be found.

/ok-to-test
can you please show some output from your terminal? why is this happening, is it because of a different systemctl version?

@neolit123

➜  sealos git:(main) cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.6 LTS"
➜  sealos git:(main) systemctl --version
systemd 245 (245.4-4ubuntu3.22)
+PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2 default-hierarchy=hybrid
➜  sealos git:(main) systemctl status noneexists
Unit noneexists.service could not be found.

i get this on ubuntu:

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.1 LTS"
$  systemctl --version
systemd 245 (245.4-4ubuntu3.2)
+PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2 default-hierarchy=hybrid
$  systemctl status noneexists
Unit noneexists.service could not be found.

/approve
to this change.

@pacoxu
PTAL to check if this is valid.

/hold

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengxsong, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@fengxsong

when detecting whether a service exists, if it does not, the output result will be like "Unit noneexists.service could not be found." on ubuntu:20.04

if you are copying this kubeadm code and using it in your code, please note that it has no API guarantees and it might change / break at any point in time.

if you are just using the kubeadm CLI and getting the error it is fine.

@neolit123

if you are copying this kubeadm code and using it in your code, please note that it has no API guarantees and it might change / break at any point in time.

I am aware of that.

/release-note-edit

kubeadm: improve the logic that checks whether a systemd service exists.

the change seems OK.
as shown in #120514 (comment) this error message is actually more accurate for recent systemd. the original message that we checked seems to be from some old version (?).

/lgtm
/triage accepted
/hold cancel

let's see if this breaks something; if yes, we must revert.

LGTM label has been added.