Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CloudDualStackNodeIPs to beta for 1.29 #120275

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Bump CloudDualStackNodeIPs to beta for 1.29 #120275

merged 1 commit into from
Sep 1, 2023
+4 −2

Conversation

danwinship
Copy link
Contributor

What type of PR is this?

/kind feature
/sig network
/priority important-soon

What this PR does / why we need it:

Updates KEP 3705 "Cloud Dual-Stack --node-ip Handling" to beta for 1.29.

Does this PR introduce a user-facing change?

The CloudDualStackNodeIPs feature is now beta, meaning that when using
an external cloud provider that has been updated to support the feature,
you can pass comma-separated dual-stack `--node-ips` to kubelet and have
the cloud provider take both IPs into account.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3705

@danwinship
Copy link
Contributor Author

/assign thockin

@danwinship danwinship mentioned this pull request Aug 30, 2023
Open
12 tasks
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Aug 30, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2023
@jiahuif
Copy link
Member

jiahuif commented Aug 31, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2023
thockin
thockin reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the KEP files, too and get the PRR check-off

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b965a00e63c234ed5ec138ea9c752a6b276d840b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@danwinship
Copy link
Contributor Author

It's already PRR'ed for beta; we were originally supposed to have gone to beta in 1.28. I submitted kubernetes/enhancements#4170 to fix the version numbers in kep.yaml though.

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 470fe39 into kubernetes:master Sep 1, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 1, 2023
@danwinship danwinship deleted the kep-3705-to-beta branch September 4, 2023 13:25
sergelogvinov added a commit to sergelogvinov/talos-cloud-controller-manager that referenced this pull request Feb 5, 2024
@sergelogvinov
feat: support CloudDualStackNodeIPs
bf0de90 
Talos CCM now supports the `CloudDualStackNodeIPs` feature gate. This feature
allows the user(cloud) to specify a list of IPv4 and IPv6 addresses for each node in
the cluster. kubernetes/kubernetes#120275

Signed-off-by: Serge Logvinov <[email protected]>
@sergelogvinov sergelogvinov mentioned this pull request Feb 5, 2024
Merged
5 tasks
sergelogvinov added a commit to sergelogvinov/talos-cloud-controller-manager that referenced this pull request Feb 5, 2024
@sergelogvinov
feat: support CloudDualStackNodeIPs
81668b7 
Talos CCM now supports the `CloudDualStackNodeIPs` feature gate. This feature
allows the user(cloud) to specify a list of IPv4 and IPv6 addresses for each node in
the cluster. kubernetes/kubernetes#120275

Signed-off-by: Serge Logvinov <[email protected]>
sergelogvinov added a commit to sergelogvinov/talos-cloud-controller-manager that referenced this pull request Feb 5, 2024
@sergelogvinov
feat: support CloudDualStackNodeIPs
c852a71 
Talos CCM now supports the `CloudDualStackNodeIPs` feature gate. This feature
allows the user(cloud) to specify a list of IPv4 and IPv6 addresses for each node in
the cluster. kubernetes/kubernetes#120275

Signed-off-by: Serge Logvinov <[email protected]>
sergelogvinov added a commit to sergelogvinov/talos-cloud-controller-manager that referenced this pull request Feb 5, 2024
@sergelogvinov
feat: support CloudDualStackNodeIPs
b4e136b 
Talos CCM now supports the `CloudDualStackNodeIPs` feature gate. This feature
allows the user(cloud) to specify a list of IPv4 and IPv6 addresses for each node in
the cluster. kubernetes/kubernetes#120275

Signed-off-by: Serge Logvinov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danwinship @jiahuif @k8s-ci-robot @thockin