Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minimize unnecessary API requests to the API server for the configmap/secret get API #120255

Merged
merged 1 commit into from
Sep 7, 2023
Merged

feat: minimize unnecessary API requests to the API server for the configmap/secret get API #120255

merged 1 commit into from
Sep 7, 2023

Conversation

likakuli
Copy link
Contributor

@likakuli likakuli commented Aug 30, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #120126

Special notes for your reviewer:

Only invoke AddReference first time when to sync same pod to minimize unnecessary API requests to the API server for the configmap/secret get API.

Does this PR introduce a user-facing change?

--sync-frequency will not affect the update interval of volumes that use ConfigMaps or Secrets when the configMapAndSecretChangeDetectionStrategy is set to Cache. The update interval is only affected by node.alpha.kubernetes.io/ttl node annotation."

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @likakuli. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 30, 2023
@likakuli
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 30, 2023
@likakuli
Copy link
Contributor Author

likakuli commented Aug 30, 2023 •
edited

@liggitt kindly ping, please help to review is this ok, thx

@likakuli likakuli changed the title feat: only invoke AddReference first time when to sync same pod to minimize unnecessary API requests to the API server for the configmap/secret get API feat: minimize unnecessary API requests to the API server for the configmap/secret get API Aug 30, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 30, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Aug 31, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 31, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Aug 31, 2023
@likakuli likakuli force-pushed the feat-addreferenceonlyfirsttime branch from 65b3cfa to f8e1fc8 Compare August 31, 2023 14:55
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2023
@likakuli
fix: only invoke AddReference first time when to sync same pod to min…
e167ecb 
…imize unnecessary API requests to the API server for the configmap/secret get API

Signed-off-by: likakuli <[email protected]>
@likakuli likakuli force-pushed the feat-addreferenceonlyfirsttime branch from f8e1fc8 to e167ecb Compare August 31, 2023 14:57
@liggitt
Copy link
Member

liggitt commented Sep 7, 2023

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 50a11d87a462b1650da9a2c11816d06e95d3df4b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, likakuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 58ce734 into kubernetes:master Sep 7, 2023
14 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@feiskyer feiskyer Awaiting requested review from feiskyer

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

kubelet get configmap from kube-apiserver and etcd everytime
4 participants
@likakuli @k8s-ci-robot @bart0sh @liggitt