Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GAed FG DownwardAPIHugePages #120249

Merged
merged 1 commit into from
Oct 16, 2023
Merged

remove GAed FG DownwardAPIHugePages #120249

merged 1 commit into from
Oct 16, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 30, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

// owner: @derekwaynecarr
// alpha: v1.20
// beta: v1.21 (off by default until 1.22)
// ga: v1.27
//
// Enables usage of hugepages- in downward API.

Which issue(s) this PR fixes:

ref #115721

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed the `DownwardAPIHugePages` feature gate (the feature is stable and always enabled)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

kubernetes/enhancements#2053

- [KEP]: https://github.com/kubernetes/enhancements/blob/b5b3585/keps/sig-node/2053-downward-api-hugepages/README.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 30, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Aug 30, 2023

/sig node
/cc @mrunalp @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 30, 2023
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Aug 30, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Aug 31, 2023

/triage accepted
/priority important-longterm
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 56dbf441fd81e3399c35751d0449fa9abd33e790

@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Aug 31, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Aug 31, 2023

/assign @derekwaynecarr @mrunalp @dchen1107

@pacoxu pacoxu moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Aug 31, 2023
@dims
Copy link
Member

dims commented Oct 15, 2023

/approve
/lgtm

@pacoxu
Copy link
Member Author

pacoxu commented Oct 15, 2023

/assign @SergeyKanzhelev @liggitt

@derekwaynecarr
Copy link
Member

the change looks good, but need an api approver for final approve.

@dims
Copy link
Member

dims commented Oct 16, 2023

/approve
/lgtm

@liggitt
Copy link
Member

liggitt commented Oct 16, 2023

/approve
for API package cleanup (no actual API changes)

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, pacoxu, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bb16282 into kubernetes:master Oct 16, 2023
15 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Oct 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 16, 2023
@pacoxu pacoxu mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dims dims

@mrunalp mrunalp

@liggitt liggitt

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@pacoxu @bart0sh @k8s-ci-robot @dims @derekwaynecarr @liggitt @SergeyKanzhelev @mrunalp @dchen1107