Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove feature gate GRPCContainerProbe #120248

Merged
merged 1 commit into from
Oct 14, 2023
Merged

remove feature gate GRPCContainerProbe #120248

merged 1 commit into from
Oct 14, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 30, 2023

/kind cleanup

xref kubernetes/enhancements#2727

  • remove the FG in v1.29
  • clean up some docs

owner: @yuzhiquan, @bowei, @PxyUp, @SergeyKanzhelev

Removed the `GRPCContainerProbe` feature gate (the feature is stable and always enabled)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2727-grpc-probe/README.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 30, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Aug 30, 2023

/priority important-soon
/cc @bowei @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 30, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Aug 30, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 30, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Aug 31, 2023

/triage accepted
/priority important-longterm
/lgtm
/assign @mrunalp @derekwaynecarr @dchen1107

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63f09b60494e18aec8477b19e507f9c80182bfe8

@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Aug 31, 2023
@pacoxu pacoxu moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Aug 31, 2023
@dims
Copy link
Member

dims commented Oct 14, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 43e617f into kubernetes:master Oct 14, 2023
15 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Oct 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 14, 2023
@pacoxu pacoxu mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@deads2k deads2k Awaiting requested review from deads2k

@bowei bowei Awaiting requested review from bowei

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@dims dims

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pacoxu @bart0sh @k8s-ci-robot @dims @mrunalp @derekwaynecarr @dchen1107