Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GAed feature gates CronJobTimeZone, JobMutableNodeSchedulingDirectives and LegacyServiceAccountTokenNoAutoGeneration #120192

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Remove GAed feature gates CronJobTimeZone, JobMutableNodeSchedulingDirectives and LegacyServiceAccountTokenNoAutoGeneration #120192

merged 1 commit into from
Oct 14, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Aug 27, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

All of these feature gates have been GAed, and can be removed since v1.29:

  • CronJobTimeZone GA at 1.27 1b825c1
  • JobMutableNodeSchedulingDirectives GA at 1.27 2ecd240
  • LegacyServiceAccountTokenNoAutoGeneration GA at 1.26 (Lock at 1.27) 4fd09a0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Removed the `CronJobTimeZone` feature gate (the feature is stable and always enabled)
- Removed the `JobMutableNodeSchedulingDirectives` feature gate (the feature is stable and always enabled)
- Removed the `LegacyServiceAccountTokenNoAutoGeneration` feature gate (the feature is stable and always enabled)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 27, 2023
@SataQiu SataQiu changed the title Remove GAed feature gates CronJobTimeZone, JobMutableNodeSchedulingDirectives, LegacyServiceAccountTokenNoAutoGeneration and RetroactiveDefaultStorageClass Remove GAed feature gates CronJobTimeZone, JobMutableNodeSchedulingDirectives and LegacyServiceAccountTokenNoAutoGeneration Aug 27, 2023
@SataQiu
remove GAed feature gates CronJobTimeZone, JobMutableNodeSchedulingDi…
6fc3d0e 
…rectives and LegacyServiceAccountTokenNoAutoGeneration
@SataQiu SataQiu force-pushed the remove-featuregate-20230827 branch from bca0fc2 to 6fc3d0e Compare August 27, 2023 08:51
@SataQiu
Copy link
Member Author

SataQiu commented Aug 27, 2023

/sig apps
/sig scheduling
/sig api-machinery
/sig auth

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2023
@pacoxu
Copy link
Member

pacoxu commented Aug 28, 2023

/lgtm
for CronJobTimeZone
/assign @soltysh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 485dfef6f187cb7020439b9815539cd96669a761

@sftim
Copy link
Contributor

sftim commented Aug 29, 2023

How I'd changelog this

- Removed the `CronJobTimeZone` feature gate (the feature is stable and always enabled)
- Removed the `JobMutableNodeSchedulingDirectives` feature gate (the feature is stable and always enabled)
- Removed the `LegacyServiceAccountTokenNoAutoGeneration` feature gate (the feature is stable and always enabled)

@alexzielenski
Copy link
Contributor

/remove-sig api-machinery

since none of features owned by apimachinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 29, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Sep 20, 2023

/cc @ahg-g @deejross @zshihang

@zshihang
Copy link
Contributor

/lgtm

@ibihim
Copy link
Contributor

ibihim commented Oct 9, 2023

/assign @liggitt

@ibihim
Copy link
Contributor

ibihim commented Oct 9, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@sftim
Copy link
Contributor

sftim commented Oct 9, 2023

This will also need docs PRs to update https://k8s.io/docs/reference/command-line-tools-reference/feature-gates/ and https://k8s.io/docs/reference/command-line-tools-reference/feature-gates-removed/

@SataQiu SataQiu mentioned this pull request Oct 10, 2023
Merged
@SataQiu
Copy link
Member Author

SataQiu commented Oct 10, 2023

This will also need docs PRs to update https://k8s.io/docs/reference/command-line-tools-reference/feature-gates/ and https://k8s.io/docs/reference/command-line-tools-reference/feature-gates-removed/

docs PR: kubernetes/website#43400

@dims
Copy link
Member

dims commented Oct 14, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9988f63 into kubernetes:master Oct 14, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@dims dims Awaiting requested review from dims

@ahg-g ahg-g Awaiting requested review from ahg-g

@deejross deejross Awaiting requested review from deejross

@zshihang zshihang Awaiting requested review from zshihang

Assignees

@soltysh soltysh

@liggitt liggitt

@pacoxu pacoxu

@zshihang zshihang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG Auth
Archived in project
SIG Scheduling
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@SataQiu @pacoxu @k8s-ci-robot @sftim @alexzielenski @zshihang @ibihim @dims @soltysh @liggitt