Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New mock test framework for windows kubeproxy. #120105

Merged
merged 1 commit into from
Sep 8, 2023
Merged

New mock test framework for windows kubeproxy. #120105

merged 1 commit into from
Sep 8, 2023

Conversation

princepereira
Copy link
Contributor

@princepereira princepereira commented Aug 22, 2023 •
edited

What type of PR is this?

/kind cleanup
/kind failing-test
/kind windows
/kind kube-proxy

What this PR does / why we need it:

This is to add mock framework for unit tests for windows in kube-proxy

Which issue(s) this PR fixes:

Fixes #120200

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

This contains the modified windows kubeproxy testcases with mock implementation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

@princepereira: The label(s) kind/windows, kind/kube-proxy cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup
/kind failing-test
/kind windows
/kind kube-proxy

What this PR does / why we need it:

This is to add mock framework for unit tests for windows in kube-proxy

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

This contains the modified windows kubeproxy testcases with mock implementation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 22, 2023
@k8s-ci-robot k8s-ci-robot added area/kube-proxy sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2023
@princepereira princepereira force-pushed the ppereira-kubeproxy-mock-tests branch 2 times, most recently from d079ae9 to 07b7d03 Compare August 22, 2023 15:57
@princepereira princepereira reopened this Aug 25, 2023
@princepereira princepereira marked this pull request as draft August 25, 2023 05:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2023
@princepereira princepereira marked this pull request as ready for review August 28, 2023 05:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2023
@jsturtevant
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2023
@jsturtevant
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-master

@jsturtevant
Copy link
Contributor

/test pull-ci-kubernetes-unit-windows

@princepereira princepereira force-pushed the ppereira-kubeproxy-mock-tests branch 3 times, most recently from 4e9276c to b1bb412 Compare September 6, 2023 15:35
@sbangari
Copy link
Contributor

sbangari commented Sep 6, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dbe0aa815ce169712883fc5c53a3f01aa2845a2c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: princepereira, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 8, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4bacfe2f70847c4c0b3b8b73056065dfc5d35d91

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 8, 2023 •
edited

@princepereira: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ci-kubernetes-unit-windows 3e358042cacc96b4a348d7caf492b98f4db78f64 link false /test pull-ci-kubernetes-unit-windows
pull-kubernetes-e2e-capz-windows-master 3e358042cacc96b4a348d7caf492b98f4db78f64 link false /test pull-kubernetes-e2e-capz-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbangari
Copy link
Contributor

sbangari commented Sep 8, 2023

/lgtm

@pacoxu
Copy link
Member

pacoxu commented Sep 8, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 80cd9d7 into kubernetes:master Sep 8, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@pacoxu pacoxu pacoxu left review comments

@daschott daschott daschott left review comments

@sbangari sbangari Awaiting requested review from sbangari

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@pacoxu pacoxu

@sbangari sbangari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

Remove the dependency of HNS in Winkernel KubeProxy Tests by replacing with mock calls.
6 participants
@princepereira @k8s-ci-robot @daschott @jsturtevant @sbangari @pacoxu