Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store validating admission as beta #120018

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Store validating admission as beta #120018

merged 2 commits into from
Aug 18, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 17, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Switches the storage version for validating admission policies / bindings to beta. This should have happened when the feature was promoted to beta, but got missed.

This PR also updates the etcd data test to catch this in the future (if a non-alpha version is available, expect the storage version to be non-alpha).

Does this PR introduce a user-facing change?

ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding objects are persisted in etcd using the v1beta1 version. Remove alpha objects or disable the alpha ValidatingAdmissionPolicy feature in a 1.27 server before upgrading to a 1.28 server with the beta feature and API enabled.

cc @jpbetz @cici37

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2023
@liggitt liggitt mentioned this pull request Aug 17, 2023
Merged
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 17, 2023
@liggitt
Copy link
Member Author

liggitt commented Aug 17, 2023

I think we should pick this back to 1.28.1 to minimize alpha data we persist while the feature is in beta

@jpbetz
Copy link
Contributor

jpbetz commented Aug 17, 2023

/lgtm
/approve
Thanks for improving the detection and messaging!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 175ba77cb528b0a8e111b9c103dc4266b1426c48

@jpbetz
Copy link
Contributor

jpbetz commented Aug 17, 2023

I support backporting this to 1.28.1

@liggitt liggitt mentioned this pull request Aug 17, 2023
Closed
@liggitt
Copy link
Member Author

liggitt commented Aug 17, 2023

/retest

@liggitt
Copy link
Member Author

liggitt commented Aug 17, 2023

oops, had to regenerate discovery to update storageVersionHash

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiahuif
Copy link
Member

jiahuif commented Aug 17, 2023

cc @cici37
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 17, 2023
@liggitt
Copy link
Member Author

liggitt commented Aug 17, 2023

#119723 flake
/retest

@alexzielenski
Copy link
Contributor

alexzielenski commented Aug 17, 2023 •
edited

This change was in the original beta promotion PR but was reverted due to comment during review concerned with upgrade interactions:

#118644 (comment)

@liggitt
Copy link
Member Author

liggitt commented Aug 17, 2023

This change was in the original beta promotion PR but was reverted due to comment during review concerned with upgrade interactions:

#118644 (comment)

Hmm... storing alpha data in etcd for a beta feature is unfortunate. It means that someone who never enabled the alpha would still be exposed to alpha data and reliance on alpha types. It's not as big a deal since the beta API is not enabled by default, so maybe we can limit this change to master and not backport it.

@liggitt
Copy link
Member Author

liggitt commented Aug 17, 2023

/retest

@SataQiu
Copy link
Member

SataQiu commented Aug 18, 2023

/test pull-kubernetes-e2e-gce
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed157ecda72243bff5206713757bab8a6a7c6f32

@SataQiu
Copy link
Member

SataQiu commented Aug 18, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit fbac838 into kubernetes:master Aug 18, 2023
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 18, 2023
@alexzielenski alexzielenski mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@deads2k deads2k Awaiting requested review from deads2k

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @jpbetz @k8s-ci-robot @jiahuif @alexzielenski @SataQiu