-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: remove 'system:masters' organization from etcd/healthcheck-client certificate #119859
kubeadm: remove 'system:masters' organization from etcd/healthcheck-client certificate #119859
Conversation
…lient certificate
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 422afe6e72281fd3016f56e3f44f9f0c14f2bc6c
|
@SataQiu we can drop the hold here, i think. |
Yes, thanks @neolit123 |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
It seems that the
etcd/healthcheck-client.crt
andetcd/healthcheck-client.key
are only used by kubeadm to talk with etcd cluster, thesystem:masters
organization is not needed in this case.kubeadm: remove 'system:masters' organization from
etcd/healthcheck-client
certificate.Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#2915
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: