-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid returning nil responseKind in v1beta1 aggregated discovery #119835
Avoid returning nil responseKind in v1beta1 aggregated discovery #119835
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023. |
/milestone v1.29 if we do this, we'll merge into 1.29 and backport, this isn't blocking for 1.28 |
(I'll add more tests if we get agreement on this direction) |
+1 from me on the direction! 🧭 |
/triage accepted |
/cc @Jefftree |
/retest |
1 similar comment
/retest |
/approve +1 for inclusion in 1.28.0 EDIT: clarified that I'd like to see this in 1.28.0 (not wait for 1.28.1) |
ffbb251
to
1876ddf
Compare
/milestone v1.28 1.27 and 1.26 picks open as well to exercise CI /hold for coordination with release team relative to rc1 |
OOMKiller flake (#119600) |
/retest |
/approve |
LGTM label has been added. Git tree hash: aa44f93e0fffc21295ab412964ccbf7b5050050f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, jpbetz, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/hold cancel per release-manager discussion in https://kubernetes.slack.com/archives/CJH2GBF7Y/p1691607686137089 |
/priority critical-urgent |
…835-upstream-release-1.27 Automated cherry pick of #119835: Avoid returning nil responseKind in v1beta1 aggregated
…835-upstream-release-1.26 Automated cherry pick of #119835: Avoid returning nil responseKind in v1beta1 aggregated
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Applies fixup to returned aggregated discovery v1beta1 to avoid sending nil responseKind fields, which v0.26.0-v0.26.3 clients cannot handle.
Which issue(s) this PR fixes:
xref #118361 #116603 #119840
Even though the nil panic in client-go was fixed in 0.26.4+, there is widespread usage of impacted versions (https://grep.app/search?q=k8s.io/client-go%20v0%5C.26%5C.%5B0123%5D®exp=true&filter[path.pattern][0]=go.mod)
Mitigating this server-side for v1beta1 seems prudent to avoid breaking clients when 1.27+ servers enable aggregated discovery by default.
cc @apelisse @seans3 @dims