Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate AdmissionWebhookMatchCondition to beta #119380

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Graduate AdmissionWebhookMatchCondition to beta #119380

merged 2 commits into from
Jul 17, 2023

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Jul 17, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This patch graduate AdmissionWebhookMatchCondition to beta.
As described in the KEP we need to ship the following PR as well:

pre-graduation:

post-graduation:

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3716

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduate `AdmissionWebhookMatchCondition` feature to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP-3716 Graduation Milestone kubernetes/enhancements#4059

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @a-hilaly. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 17, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ivelichkovich
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2023
@cici37
Copy link
Contributor

cici37 commented Jul 17, 2023

/lgtm
Thank you :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 96e71c5c21306d70e1bc913a6a598455b2be2950

@ivelichkovich
Copy link
Contributor

/hold

until this merges: #119342 and confirming ValidatingAdmissionPolicy made beta graduation

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@a-hilaly a-hilaly mentioned this pull request Jul 17, 2023
Merged
@a-hilaly
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@ivelichkovich
Copy link
Contributor

PR is merged and okay to not wait for validatingadmissionpolicy

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

@ivelichkovich: GitHub didn't allow me to assign the following users: liggit.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign liggit

for api-review since we updated comments in apis files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ivelichkovich
Copy link
Contributor

/assign liggitt

for api-review since we updated comments in apis files

@a-hilaly a-hilaly force-pushed the api-server/webhooks/match-conditions-beta-graduations branch from 12afa48 to 94c8ad2 Compare July 17, 2023 21:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@ivelichkovich
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9b472eb291829dd7a287d872825af5aef3582305

@liggitt
Copy link
Member

liggitt commented Jul 17, 2023

API change lgtm, would like an ack on the feature graduation from an api-machinery reviewer (probably @jpbetz since he reviewed several of the prereq PRs)

@jpbetz
Copy link
Contributor

jpbetz commented Jul 17, 2023

/approve
For feature completeness against beta graduation criteria.

Thanks @a-hilaly!

@liggitt
Copy link
Member

liggitt commented Jul 17, 2023

/approve

for API doc change

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7049708 into kubernetes:master Jul 17, 2023
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 17, 2023
@Atharva-Shinde Atharva-Shinde mentioned this pull request Jul 19, 2023
Closed
12 tasks
@a-hilaly a-hilaly mentioned this pull request Jul 19, 2023
Closed
9 tasks
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2023
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivelichkovich ivelichkovich ivelichkovich left review comments

@cici37 cici37 Awaiting requested review from cici37

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@cici37 cici37

@ivelichkovich ivelichkovich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@a-hilaly @k8s-ci-robot @k8s-triage-robot @ivelichkovich @cici37 @liggitt @jpbetz @alexzielenski