Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KUBECTL_EXPLAIN_OPENAPIV3 environment variable #119286

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Remove KUBECTL_EXPLAIN_OPENAPIV3 environment variable #119286

merged 1 commit into from
Jul 13, 2023
+2 −6

Conversation

ardaguclu
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Since explain openapiv3 has been moved to beta already with this #116390, there is no point to having this environment variable.

This PR removes it.

Does this PR introduce a user-facing change?

Remove KUBECTL_EXPLAIN_OPENAPIV3 which is already redundant

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 13, 2023
@ardaguclu
Copy link
Member Author

/cc @alexzielenski @apelisse
I think, we also need to remove this environment variable from documents https://github.com/kubernetes/website/blob/5da7cb5e7c7a066439a5227075fb8268f68c73a6/content/en/docs/reference/kubectl/kubectl.md?plain=1#L356-L362

@ardaguclu
Remove KUBECTL_EXPLAIN_OPENAPIV3 environment variable
4d8f569 
Since explain openapiv3 has been moved to beta already, there is no
point to having this environment variable.

This PR removes it.
@ardaguclu
Copy link
Member Author

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 13, 2023
@apelisse
Copy link
Member

Yeah, it doesn't even do anything ... Thanks Arda!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2eda8388b7b6582aa156ffaadda6017a695e8ae0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d399652 into kubernetes:master Jul 13, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 13, 2023
@ardaguclu ardaguclu deleted the remove-openapiv3-alpha-env branch July 13, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@soltysh soltysh Awaiting requested review from soltysh

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ardaguclu @apelisse @k8s-ci-robot