Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cadvisor version to v0.47.3 #119225

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Bump cadvisor version to v0.47.3 #119225

merged 1 commit into from
Jul 11, 2023

Conversation

iholder101
Copy link
Contributor

What type of PR is this?

let's move to a newer cadvisor version.

It also contains a bugfix that swap implementation is dependent on in order to graduate swap to Beta1.

/kind bug
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bump cadvisor version to v0.47.3

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @iholder101. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, dims and a team July 11, 2023 13:40
@iholder101
Copy link
Contributor Author

/sig node
/cc @bobbypage @dims @harche @mrunalp

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/dependency Issues or PRs related to dependency changes area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 11, 2023
@swatisehgal
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2023
@harche
Copy link
Contributor

harche commented Jul 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b32084cd34ab302df1061cb9616cfcd25c4c97e

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from harche July 11, 2023 14:22
@harche
Copy link
Contributor

harche commented Jul 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a45c0f0f1999bc513826fb66502a458d83183785

@iholder101
Copy link
Contributor Author

iholder101 commented Jul 11, 2023 •
edited

Unit tests pass locally

/test pull-kubernetes-unit

@harche
Copy link
Contributor

harche commented Jul 11, 2023

/cc @dep-approvers

@harche
Copy link
Contributor

harche commented Jul 11, 2023

cc @kubernetes/dep-approvers

@bobbypage
Copy link
Member

/lgtm

@bobbypage bobbypage mentioned this pull request Jul 11, 2023
Merged
SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dims can you approve?

@dims
Copy link
Member

dims commented Jul 11, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, harche, iholder101, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@iholder101
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d45b6ba into kubernetes:master Jul 11, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 11, 2023
This was referenced Jul 12, 2023
Merged
Merged
Closed
@iholder101 iholder101 mentioned this pull request Jul 21, 2023
Closed
31 tasks
@humblec humblec mentioned this pull request Sep 5, 2023
Open
humblec added a commit to humblec/kubernetes that referenced this pull request Sep 5, 2023
@humblec
cadvior bump to 0.47.3 in build dependencies.
31cbc7b 
The cadvisor has been bumped to 0.47.3 via
kubernetes#119225

This update the same in build.

Signed-off-by: Humble Chirammal <[email protected]>
@pacoxu pacoxu mentioned this pull request Sep 18, 2023
Open
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@dims dims Awaiting requested review from dims

@bobbypage bobbypage Awaiting requested review from bobbypage

@harche harche Awaiting requested review from harche

Assignees

@dims dims

@bobbypage bobbypage

@SergeyKanzhelev SergeyKanzhelev

@harche harche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@iholder101 @k8s-ci-robot @swatisehgal @harche @bobbypage @dims @mrunalp @SergeyKanzhelev