Skip to content

[wip] cadvisor bump to 0.48.1 in build dependencies. #120415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[wip] cadvisor bump to 0.48.1 in build dependencies. #120415

wants to merge 1 commit into from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Sep 5, 2023 •
edited
Loading

make use of cadvisor 0.48.1 as dependencies are on 0.48.1

This update the same in build and test images.

/kind cleanup

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 5, 2023
@humblec
Copy link
Contributor Author

humblec commented Sep 5, 2023

/assign @dims

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: humblec
Once this PR has been reviewed and has the lgtm label, please ask for approval from dims. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2023
@humblec
Copy link
Contributor Author

humblec commented Sep 5, 2023

/triage accepted
/priority-important-long-term

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 5, 2023
@humblec humblec changed the title cadvior bump to 0.47.3 in build dependencies. [wip] cadvior bump to 0.47.3 in build dependencies. Sep 5, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023
@humblec
Copy link
Contributor Author

humblec commented Sep 5, 2023

0905 07:44:42.646] E0905 07:44:32.205978 1916 remote_image.go:180] "PullImage from image service failed" err="rpc error: code = NotFound desc = failed to pull and unpack image \"gcr.io/cadvisor/cadvisor:v0.47.3\": failed to resolve reference \"gcr.io/cadvisor/cadvisor:v0.47.3\": gcr.io/cadvisor/cadvisor:v0.47.3: not found" image="gcr.io/cadvisor/cadvisor:v0.47.3"

@humblec humblec changed the title [wip] cadvior bump to 0.47.3 in build dependencies. [wip] cadvisor bump to 0.47.3 in build dependencies. Sep 5, 2023
@humblec
Copy link
Contributor Author

humblec commented Sep 6, 2023

Trying to get help from @bobbypage ( sig-node) to get the latest image pushed into the gcr.io.

@dims
Copy link
Member

dims commented Jan 2, 2024

any update on this @humblec ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2024
@humblec humblec changed the title [wip] cadvisor bump to 0.47.3 in build dependencies. [wip] cadvisor bump to 0.48.1 in build dependencies. Feb 15, 2024
@humblec
Copy link
Contributor Author

humblec commented Feb 15, 2024 •
edited
Loading

The last image I see in gcr.io registry is v0.47.2, eventhough the releases are available till 0.48.1

: Pulling from cadvisor/cadvisor
Digest: sha256:78cf73632de30193dc249923fdfdb1d43ee7cfccbf64662991de89ff7c4b1fda
Status: Image is up to date for gcr.io/cadvisor/cadvisor:v0.47.2

@dims is latest image available somewhere?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 15, 2024 •
edited
Loading

@humblec: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd 2e919fb link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-verify 2e919fb link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2024
@dims
Copy link
Member

dims commented May 30, 2024

there's a PR to update to a newer version. let's use that please. thanks!

#125120

/close

@k8s-ci-robot
Copy link
Contributor

@dims: Closed this PR.

In response to this:

there's a PR to update to a newer version. let's use that please. thanks!

#125120

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco Awaiting requested review from puerco

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@dims dims

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@humblec @k8s-ci-robot @dims @k8s-triage-robot