Add reason to force detach metric #119185
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/sig storage |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6eeaec2
to
cca6601
Compare
|
/retest |
| "node", klog.KRef("", string(attachedVolume.NodeName)), | ||
| "volumeName", attachedVolume.VolumeName) | ||
| } else { | ||
| metrics.RecordForcedDetachMetric(metrics.ForceDetachReasonOutOfService) |
There was a problem hiding this comment.
This is slightly different behavior---we didn't log on the out of service taint before?
Regardless, seems like a good idea to do this.
There was a problem hiding this comment.
Yes. When trying to add reason for the forced detach, I noticed that this logic should change a little bit so that forced detach due to out-of-service taint should get a different logging message.
|
/lgtm |
|
LGTM label has been added. Git tree hash: cecb676ed4d1d7681f2d6ceadee910dd7c4d42fb
|
|
Makes sense. /lgtm |
What type of PR is this?
Add one of the following kinds:
/kind feature
What this PR does / why we need it:
Add reason to metric
"attachdetach_controller_forced_detaches.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: