Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodeaffinity: scheduler queueing hints #119155

Merged
merged 1 commit into from
Oct 19, 2023
Merged

nodeaffinity: scheduler queueing hints #119155

merged 1 commit into from
Oct 19, 2023

Conversation

carlory
Copy link
Member

@carlory carlory commented Jul 7, 2023 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #118893

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-scheduler implements scheduling hints for the NodeAffinity plugin.
The scheduling hints allow the scheduler to only retry scheduling a Pod
that was previously rejected by the NodeAffinity plugin if a new Node or a Node update matches the Pod's node affinity.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 7, 2023
@sanposhiho
Copy link
Member

@carlory Please /assign @sanposhiho when this PR is ready to get reviews

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2023
@carlory carlory changed the title [WIP] nodeaffinity: scheduler queueing hints nodeaffinity: scheduler queueing hints Jul 8, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2023
@carlory
Copy link
Member Author

carlory commented Jul 8, 2023

/assign @sanposhiho

sanposhiho
sanposhiho reviewed Jul 8, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review.

pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go Outdated Show resolved Hide resolved
@carlory carlory force-pushed the fix-118893-1 branch 4 times, most recently from 6e33509 to 222f0b4 Compare July 8, 2023 08:41
sanposhiho
sanposhiho reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one last nit, otherwise LGTM.
/lgtm

@kubernetes/sig-scheduling-approvers Please someone give a final review for /approve (I'm assigned to this PR as both reviewer/approver)

pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a91cd1a34a2b04e548be2bae830463ec10a23ad9

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
sanposhiho
sanposhiho reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing slipped.

pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go Outdated Show resolved Hide resolved
sanposhiho
sanposhiho reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf2f2c4cae9a85fb79f8e767ad4c146fc21c2192

@carlory carlory mentioned this pull request Oct 8, 2023
Merged
@carlory
Copy link
Member Author

carlory commented Oct 11, 2023

Hi @alculquicondor can you take a look?

@carlory
Copy link
Member Author

carlory commented Oct 13, 2023

@kubernetes/sig-scheduling-approvers Please someone give a final review for /approve

alculquicondor
alculquicondor reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go
return framework.QueueAfterBackoff
}

requiredNodeAffinity := nodeaffinity.GetRequiredNodeAffinity(pod)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @sanposhiho. We are already parsing node affinity for the static checks, so we know this scales just fine.
But we need to remove those static checks, otherwise we are doing it twice per pod.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, carlory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@alculquicondor
Copy link
Member

/release-note-edit

kube-scheduler implements scheduling hints for the NodeAffinity plugin.
The scheduling hints allow the scheduler to only retry scheduling a Pod
that was previously rejected by the NodeAffinity plugin if a new Node or a Node update matches the Pod's node affinity.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 18, 2023
@alculquicondor alculquicondor mentioned this pull request Oct 18, 2023
Open
12 tasks
@sanposhiho
Copy link
Member

/retest

@pacoxu
Copy link
Member

pacoxu commented Oct 19, 2023

/retest
for the flake that is tracked in #121209

@carlory
Copy link
Member Author

carlory commented Oct 19, 2023

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit ff4ba92 into kubernetes:master Oct 19, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 19, 2023
@carlory carlory deleted the fix-118893-1 branch October 19, 2023 07:50
@Vyom-Yadav Vyom-Yadav mentioned this pull request Dec 13, 2023
Closed
@carlory carlory mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@kerthcet kerthcet kerthcet left review comments

@wackxu wackxu wackxu left review comments

@ahg-g ahg-g ahg-g left review comments

@sanposhiho sanposhiho sanposhiho left review comments

@AxeZhan AxeZhan AxeZhan left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Scheduling
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet