Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GA featuregate about JobTrackingWithFinalizers in 1.28 #119100

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Remove GA featuregate about JobTrackingWithFinalizers in 1.28 #119100

merged 1 commit into from
Oct 14, 2023

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Jul 5, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove GA featuregate for JobTrackingWithFinalizers in 1.28

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @bzsuni. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin July 5, 2023 12:00
@bzsuni bzsuni changed the title Remove GA featuregate about JobTrackingWithFinalizers Remove GA featuregate about JobTrackingWithFinalizers in 1.28 Jul 5, 2023
@kannon92
Copy link
Contributor

kannon92 commented Jul 5, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2023
@kannon92
Copy link
Contributor

kannon92 commented Jul 5, 2023

/sig apps

Please add a release note. "Remove GA featuregate for JobTrackingWithFinalizers in 1.28" would be fine I think.

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 5, 2023
@bzsuni bzsuni force-pushed the ga/JobTrackingWithFinalizers branch from 872f94f to d21f795 Compare July 6, 2023 01:46
@bzsuni
Copy link
Contributor Author

bzsuni commented Jul 6, 2023 •
edited

Please add a release note. "Remove GA featuregate for JobTrackingWithFinalizers in 1.28" would be fine I think.

Yes, you are right, I have stated it in the commit, thank you!

@kannon92
Copy link
Contributor

kannon92 commented Jul 6, 2023

Please add a release note. "Remove GA featuregate for JobTrackingWithFinalizers in 1.28" would be fine I think.

Yes, you are right, I have stated it in the commit, thank you!

I suggest reading this: https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md

The issue is that the automation is not picking up the release note from the PR. The template for the PR included a place where you can put the release note.

@kannon92
Copy link
Contributor

kannon92 commented Jul 6, 2023

Please add a release note. "Remove GA featuregate for JobTrackingWithFinalizers in 1.28" would be fine I think.

Yes, you are right, I have stated it in the commit, thank you!

I suggest reading this: https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md

The issue is that the automation is not picking up the release note from the PR. The template for the PR included a place where you can put the release note.

You should follow the template when creating a PR (I’ve learned this the hard way lol). Easiest thing may just be to recreate the PR and fill out the release note section in the PR.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 7, 2023
@bzsuni
Copy link
Contributor Author

bzsuni commented Jul 7, 2023

I suggest reading this: https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md

The issue is that the automation is not picking up the release note from the PR. The template for the PR included a place where you can put the release note.

Your comments is very helpful to me, thank you!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2023
@bzsuni bzsuni force-pushed the ga/JobTrackingWithFinalizers branch from d21f795 to feb65b0 Compare July 20, 2023 06:19
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2023
SataQiu
SataQiu reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 75a4da11bb1364e1394c3dbb1368ddebd49629ad

@bzsuni bzsuni force-pushed the ga/JobTrackingWithFinalizers branch from feb65b0 to 7abade7 Compare August 2, 2023 09:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@bzsuni
Copy link
Contributor Author

bzsuni commented Aug 2, 2023

I performed a rebase operation, can you retest it for me? @SataQiu

@bzsuni bzsuni force-pushed the ga/JobTrackingWithFinalizers branch from 7abade7 to 14e7d97 Compare September 5, 2023 06:36
@bzsuni
Copy link
Contributor Author

bzsuni commented Sep 6, 2023

cc @SataQiu

SataQiu
SataQiu reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cdedec3ecab01bd32d5d8e18e67ba93bfb116219

@bzsuni
Copy link
Contributor Author

bzsuni commented Sep 7, 2023

Hi，
/assign @seans3
I kindly request your assistance in approving this pr.
If you have any questions or need additional information, please don't hesitate to leave a comment.
thanks

@bzsuni
Copy link
Contributor Author

bzsuni commented Sep 18, 2023

Would you mind sparing a moment to help me review my PR? thanks very much @seans3

@dims
Copy link
Member

dims commented Oct 14, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bzsuni, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 414a5f6 into kubernetes:master Oct 14, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@seans3 seans3

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bzsuni @k8s-ci-robot @kannon92 @dims @SataQiu @seans3