Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Pod Scheduling SLI Duration metric #119049

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat: Add Pod Scheduling SLI Duration metric #119049

merged 1 commit into from
Aug 15, 2023

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Jul 3, 2023

Add a new scheduler metric, pod_scheduling_sli_duration_seconds.

What type of PR is this?

/kind feature
/sig scheduling

What this PR does / why we need it:

As a final change to the update related to KEP #3521, discussion can be found here.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes. New metric, pod_scheduling_sli_duration_seconds

Add a new scheduler metric, `pod_scheduling_sli_duration_seconds`, and start the deprecation for `pod_scheduling_duration_seconds`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP #3521

@helayoty helayoty added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 3, 2023
@kubernetes kubernetes deleted a comment from k8s-ci-robot Jul 3, 2023
@helayoty
Copy link
Member Author

helayoty commented Jul 3, 2023

/test pull-kubernetes-node-e2e-containerd

@helayoty helayoty added this to the v1.28 milestone Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/stable-metrics Issues or PRs involving stable metrics sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2023
@k8s-triage-robot
Copy link

This PR may require stable metrics review.

Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2023
@helayoty helayoty requested a review from Huang-Wei July 3, 2023 21:54
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2023
@valaparthvi
Copy link

Hello @helayoty,
I am checking in on behalf of the Bug Triage release team. We are only a week away from Code Freeze (01:00 UTC Wednesday 19th July 2023 / 18:00 PDT Tuesday 18th July 2023). Please ensure your PR goes in by then if you are targeting 1.28 release.

Please let me know if I can be of any assistance :)

@Huang-Wei
Copy link
Member

LGTM. @helayoty could you squash the commits?

alculquicondor
alculquicondor reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label tide/merge-method-squash

pkg/scheduler/metrics/metrics.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 12, 2023
@logicalhan
Copy link
Member

/triage accepted
/assign

@furkatgofurov7
Copy link
Member

@helayoty hi, Bug Triage Lead here 👋🏼

Since it was communicated in earlier weeks (3 & 1 weeks before), Code Freeze Deadline passed and, this PR has not made to the current milestone, hence I am moving this PR to the next milestone.

/milestone next-candidate

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, next-candidate Jul 27, 2023
@helayoty @alculquicondor
Add Pod Scheduling SLI Duration metric
4d091b8 
Signed-off-by: Heba Elayoty <[email protected]>
Co-authored-by: Aldo Culquicondor <[email protected]>
@helayoty
Copy link
Member Author

helayoty commented Aug 7, 2023

@furkatgofurov7 @alculquicondor , just back from vacation. The PR was ready to merge but just needed a squash. I did that now, and it's up to you to decide if we need an exception or if it can wait for the next release.

logicalhan
logicalhan approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 320cae4c9b98d06bde6efeb983a1b9b69aabd57f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helayoty, Huang-Wei, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Aug 7, 2023 •
edited

@furkatgofurov7 @alculquicondor , just back from vacation. The PR was ready to merge but just needed a squash. I did that now, and it's up to you to decide if we need an exception or if it can wait for the next release.

@helayoty I am fine with both options, although I do not know if we have still time for exception. Tagging 1.28 Release Lead for visibilty

/cc @gracenng

@alculquicondor
Copy link
Member

I'm inclined to leave this for the next release

@k8s-ci-robot k8s-ci-robot merged commit 224087a into kubernetes:master Aug 15, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot modified the milestones: next-candidate, v1.29 Aug 15, 2023
@helayoty helayoty deleted the new-matric branch August 15, 2023 22:19
@alculquicondor alculquicondor mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

@damemi damemi Awaiting requested review from damemi

@denkensk denkensk Awaiting requested review from denkensk

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@gracenng gracenng Awaiting requested review from gracenng

Assignees

@logicalhan logicalhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/stable-metrics Issues or PRs involving stable metrics area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@helayoty @k8s-triage-robot @valaparthvi @Huang-Wei @logicalhan @furkatgofurov7 @k8s-ci-robot @alculquicondor