[Scheduler]Translate beta label to ga in volume_zone #118923
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -229,6 +229,18 @@ func TestSingleZone(t *testing.T) { | |||
| }, | |||
| wantFilterStatus: framework.NewStatus(framework.UnschedulableAndUnresolvable, ErrReasonConflict), | |||
| }, | |||
| { | |||
| name: "pv with beta label,node with ga label", | |||
There was a problem hiding this comment.
One thing I'm not sure is: in this pr, we let pv with beta label to be scheduled to node with ga label.
Should we make this work the other way around as well? That is, pv with ga label to be scheduled to node with beta label.
There was a problem hiding this comment.
I think it is fine to leave out. We converted PVs to use the GA label after introducing the GA label on Nodes.
|
/cc @msau42 |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6d4aac763df12e4682c0ca2feb6688badf396108
|
|
/assign @alculquicondor |
|
ping @alculquicondor |
| @@ -227,6 +241,10 @@ func (pl *VolumeZone) Filter(ctx context.Context, cs *framework.CycleState, pod | |||
|
|
|||
| for _, pvTopology := range podPVTopologies { | |||
| v, ok := node.Labels[pvTopology.key] | |||
| if !ok && isBetaLabel(pvTopology.key) { | |||
There was a problem hiding this comment.
I think this would be enough?
| if !ok && isBetaLabel(pvTopology.key) { | |
| if !ok { |
There was a problem hiding this comment.
Hmmm. Yes, this will make the code cleaner🤔️.
17e28f6
to
af26ebd
Compare
|
LGTM label has been added. Git tree hash: 79c823a1ef84813b438858f8ae5c0ba10f8dfaae
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, AxeZhan, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Translate beta topology label to ga when using scheduler plugin volume_zone, allow PVs with beta labels be scheduled to nodes with GA labels
Which issue(s) this PR fixes:
Fixes #114996
Special notes for your reviewer:
Previously #115225
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: