-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: backdate generated CAs #118922
kubeadm: backdate generated CAs #118922
Conversation
Signed-off-by: Etienne Champetier <[email protected]>
This allow for a small time jump backward after certificates generation. Signed-off-by: Etienne Champetier <[email protected]>
Hi @champtar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/ok-to-test
thanks
LGTM label has been added. Git tree hash: bd917f911ef8d48f22deb5b8071007cf69a978cc
|
/release-note-edit
highlighting the user facing change (kubeadm) first as per the slack discussion. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: champtar, deads2k, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While trying to cherry-pick this PR, older branch are missing #117791, should I send cherry-pick for this other PR first ? |
odd, i thought that was backported. cc @nnmin-aws |
sorry, I meant that I get a git conflict |
/triage accepted |
…8922-upstream-release-1.25 Automated cherry pick of #118922: kubeadm: backdate generated CAs
…8922-upstream-release-1.26 Automated cherry pick of #118922: kubeadm: backdate generated CAs
…8922-upstream-release-1.27 Automated cherry pick of #118922: kubeadm: backdate generated CAs
What type of PR is this?
/kind feature
What this PR does / why we need it:
When running kubeadm / installing k8s early during boot, the CA certificate can be generated before time is synchronised and time is jumped backward.
Make notBefore 5 min in the past to accept small clock jump.
Which issue(s) this PR fixes:
Special notes for your reviewer:
new version of #118631
Does this PR introduce a user-facing change?