Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use table-driven test for TestPerPodSchedulingMetrics #118842

Merged
merged 1 commit into from
Jun 30, 2023
Merged

test: Use table-driven test for TestPerPodSchedulingMetrics #118842

merged 1 commit into from
Jun 30, 2023
+95 −88

Conversation

helayoty
Copy link
Member

What type of PR is this?

Following up on the PR #118049 (comment) discussion to use table-driven test to make tests easier to debug in the future.

/kind cleanup
/sig scheduling

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No.

Use table-driven test for TestPerPodSchedulingMetrics

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2023
@helayoty
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 24, 2023
@helayoty helayoty added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 24, 2023
@helayoty helayoty requested a review from AxeZhan June 26, 2023 20:58
@alculquicondor
Copy link
Member

/assign @ahg-g

@helayoty helayoty requested a review from ahg-g June 29, 2023 21:20
@ahg-g
Copy link
Member

ahg-g commented Jun 29, 2023

Thanks, looks good to me, pls squash.

@helayoty
Copy link
Member Author

Thanks, looks good to me, pls squash.

Done.

@helayoty helayoty added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 29, 2023
@ahg-g
Copy link
Member

ahg-g commented Jun 29, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 58025039532ee46afff4cad6db0bf8f674b7da75

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, helayoty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@helayoty helayoty added this to the v1.28 milestone Jun 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 02f09d6 into kubernetes:master Jun 30, 2023
12 checks passed
@helayoty helayoty deleted the sched-update-unit-tests branch June 30, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@chendave chendave Awaiting requested review from chendave

@damemi damemi Awaiting requested review from damemi

@AxeZhan AxeZhan Awaiting requested review from AxeZhan

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@helayoty @alculquicondor @ahg-g @k8s-ci-robot @AxeZhan