Exempt borrowing implementation #118782
Merged
Exempt borrowing implementation #118782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
/assign @wojtek-t |
d883c7d
to
45156e1
Compare
|
The force-push to 45156e107fd is a rebase onto |
45156e1
to
77afe54
Compare
77afe54
to
4da07df
Compare
|
/test gce-master-scale-performance |
|
@MikeSpreitzer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-e2e-gce-big-performance |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
Signed-off-by: Mike Spreitzer <[email protected]>
Signed-off-by: Mike Spreitzer <[email protected]>
Signed-off-by: Mike Spreitzer <[email protected]>
Signed-off-by: Mike Spreitzer <[email protected]>
Signed-off-by: Mike Spreitzer <[email protected]>
Signed-off-by: Mike Spreitzer <[email protected]>
Co-authored-by: David Eads <[email protected]> Signed-off-by: Mike Spreitzer <[email protected]>
f410f52
to
ce90eb2
Compare
|
@MikeSpreitzer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 28d44bdbcf517cee9a7ded21221ba8135bb020ee
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is intended to implement a recent enhancement to https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1040-priority-and-fairness#dispatching , borrowing by the exempt priority level.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@tkashem started the work on this, in #117703 . He has gone on vacation and I am picking up the work.
This PR is not complete yet. It still needs to (a) change the config-consuming controller to connect the new configuration possibility with the corresponding new behavior in QueueSet and (b) finish adjusting the config-producing controller.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @wojtek-t
/cc @deads2k
@tkashem
@lavalamp