Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump to cAdvisor v0.47.2 #118774

Merged
merged 1 commit into from
Jun 21, 2023
Merged

deps: Bump to cAdvisor v0.47.2 #118774

merged 1 commit into from
Jun 21, 2023
+15 −9

Conversation

harche
Copy link
Contributor

@harche harche commented Jun 20, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bump cAdvisor to latest version to v0.47.2

Which issue(s) this PR fixes:

Fixes # #118796

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updated cAdvisor to v0.47.2 - Fix metrics in cri-o when a container restarts

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@harche
deps: Bump to cAdvisor v0.47.2
409bc8c 
Signed-off-by: Harshal Patil <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims, logicalhan and a team June 20, 2023 19:12
@dims
Copy link
Member

dims commented Jun 20, 2023

/sig node
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 557e82bb80025d42096c6774b494ee978b3854d9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, harche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@harche
Copy link
Contributor Author

harche commented Jun 20, 2023

/test pull-kubernetes-e2e-kind-ipv6

@bobbypage
Copy link
Member

bobbypage commented Jun 20, 2023 •
edited

Can you please add to the release note what has changed (i.e. the fix that went in). I'd also suggest to create a single issue to track the fix and reference it in all the backports so it can be one place.

@harche
Copy link
Contributor Author

harche commented Jun 20, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2023
@harche
Copy link
Contributor Author

harche commented Jun 21, 2023

@bobbypage Thanks for your input. I have created a bug, #118796 as well as have updated the release notes.

Thanks.

@harche
Copy link
Contributor Author

harche commented Jun 21, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@haircommander
Copy link
Contributor

nit: I think the release note should mention what it actually does: Fix metrics in cri-o when a container restarts

@harche
Copy link
Contributor Author

harche commented Jun 21, 2023

nit: I think the release note should mention what it actually does: Fix metrics in cri-o when a container restarts

@haircommander updated, thanks.

@haircommander
Copy link
Contributor

/lgtm

thanks!

@haircommander
Copy link
Contributor

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit b8d4eec into kubernetes:master Jun 21, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 21, 2023
@pacoxu pacoxu mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dims dims

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harche @dims @k8s-ci-robot @bobbypage @haircommander