-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubectl: Improve conditionFuncFor expression parsing for wait --for jsonpath #118748
Conversation
Hi @andreaskaris. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig cli |
baa55b4
to
cf3b640
Compare
cf3b640
to
d3827da
Compare
d3827da
to
d4ae922
Compare
d4ae922
to
e286339
Compare
@ardaguclu can you /ok-to-test? |
/ok-to-test |
e286339
to
aaf69bd
Compare
aaf69bd
to
16a973d
Compare
/retest |
Make it possible to parse jsonpath filter expressions: Split jsonpath expressions on single '=' only and leave '==' as part of the string. Reported-at: https://github.com/kubernetes/kubernetes/issues/119206 Signed-off-by: Andreas Karis <[email protected]>
16a973d
to
4188998
Compare
/cc @mpuckett159 |
/lgtm |
LGTM label has been added. Git tree hash: 8d1bc771e04dc03b5c8c5a526ea96ff0940dd7a1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreaskaris, brianpursley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
i'm running into this issue and looking forward to this PR merging |
If I understand this correctly, then K8s is currently in code freeze, so it should merge after that hopefully |
Make it possible to parse jsonpath filter expressions: Split jsonpath expressions on single '=' only and leave '==' as part of the string.
Reported-at: kubernetes/kubectl#1224
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR improves handling of the jsonpath expression in wait --for.
Which issue(s) this PR fixes:
Fixes: kubernetes/kubectl#1448
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Allow parsing a wider range of jsonpath expressions in
kubectl wait --for
.Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: